Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Rename TolerateNoHandler to AllowNoHandlerMiddleware #27163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2018
Merged

[Messenger] Rename TolerateNoHandler to AllowNoHandlerMiddleware #27163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...essenger/Middleware/TolerateNoHandler.php → ...r/Middleware/AllowNoHandlerMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
/**
* @author Samuel Roze <[email protected]>
*/
class TolerateNoHandler implements MiddlewareInterface
class AllowNoHandlerMiddleware implements MiddlewareInterface
{
public function handle($message, callable $next)
{
try {
return $next($message);
} catch (NoHandlerForMessageException $e) {
// We tolerate not having a handler for this message.
// We allow not having a handler for this message.
}
}
}
8 changes: 4 additions & 4 deletions src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
use Symfony\Component\Messenger\Handler\ChainHandler;
use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
use Symfony\Component\Messenger\MessageBusInterface;
use Symfony\Component\Messenger\Middleware\TolerateNoHandler;
use Symfony\Component\Messenger\Middleware\AllowNoHandlerMiddleware;
use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
use Symfony\Component\Messenger\Tests\Fixtures\SecondMessage;
Expand Down Expand Up @@ -264,14 +264,14 @@ public function testRegistersMiddlewaresFromServices()
{
$container = $this->getContainerBuilder();
$container->register($fooBusId = 'messenger.bus.foo', MessageBusInterface::class)->setArgument(0, array())->addTag('messenger.bus', array('name' => 'foo'));
$container->register('messenger.middleware.tolerate_no_handler', TolerateNoHandler::class)->setAbstract(true);
$container->register('messenger.middleware.allow_no_handler', AllowNoHandlerMiddleware::class)->setAbstract(true);
$container->register(UselessMiddleware::class, UselessMiddleware::class);

$container->setParameter($middlewaresParameter = $fooBusId.'.middlewares', array(UselessMiddleware::class, 'tolerate_no_handler'));
$container->setParameter($middlewaresParameter = $fooBusId.'.middlewares', array(UselessMiddleware::class, 'allow_no_handler'));

(new MessengerPass())->process($container);

$this->assertTrue($container->hasDefinition($childMiddlewareId = $fooBusId.'.middleware.tolerate_no_handler'));
$this->assertTrue($container->hasDefinition($childMiddlewareId = $fooBusId.'.middleware.allow_no_handler'));
$this->assertEquals(array(new Reference(UselessMiddleware::class), new Reference($childMiddlewareId)), $container->getDefinition($fooBusId)->getArgument(0));
$this->assertFalse($container->hasParameter($middlewaresParameter));
}
Expand Down
10 changes: 5 additions & 5 deletions ...ests/Middleware/TolerateNoHandlerTest.php → ...ddleware/AllowNoHandlerMiddlewareTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@

use PHPUnit\Framework\TestCase;
use Symfony\Component\Messenger\Exception\NoHandlerForMessageException;
use Symfony\Component\Messenger\Middleware\TolerateNoHandler;
use Symfony\Component\Messenger\Middleware\AllowNoHandlerMiddleware;
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;

class TolerateNoHandlerTest extends TestCase
class AllowNoHandlerMiddlewareTest extends TestCase
{
public function testItCallsNextMiddlewareAndReturnsItsResult()
{
Expand All @@ -25,7 +25,7 @@ public function testItCallsNextMiddlewareAndReturnsItsResult()
$next = $this->createPartialMock(\stdClass::class, array('__invoke'));
$next->expects($this->once())->method('__invoke')->with($message)->willReturn('Foo');

$middleware = new TolerateNoHandler();
$middleware = new AllowNoHandlerMiddleware();
$this->assertSame('Foo', $middleware->handle($message, $next));
}

Expand All @@ -34,7 +34,7 @@ public function testItCatchesTheNoHandlerException()
$next = $this->createPartialMock(\stdClass::class, array('__invoke'));
$next->expects($this->once())->method('__invoke')->will($this->throwException(new NoHandlerForMessageException()));

$middleware = new TolerateNoHandler();
$middleware = new AllowNoHandlerMiddleware();

$this->assertNull($middleware->handle(new DummyMessage('Hey'), $next));
}
Expand All @@ -48,7 +48,7 @@ public function testItDoesNotCatchOtherExceptions()
$next = $this->createPartialMock(\stdClass::class, array('__invoke'));
$next->expects($this->once())->method('__invoke')->will($this->throwException(new \RuntimeException('Something went wrong.')));

$middleware = new TolerateNoHandler();
$middleware = new AllowNoHandlerMiddleware();
$middleware->handle(new DummyMessage('Hey'), $next);
}
}