Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Routing] Fix adding name prefix to canonical route names #27270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2018
Merged

[Routing] Fix adding name prefix to canonical route names #27270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix bug when imported routes are prefixed
  • Loading branch information
@ismail1432
ismail1432 committed May 15, 2018
commit cb5ce8f32ebb4217c291331590b8ed1cb1e5ca4f
3 changes: 3 additions & 0 deletions src/Symfony/Component/Routing/RouteCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ public function addNamePrefix(string $prefix)

foreach ($this->routes as $name => $route) {
$prefixedRoutes[$prefix.$name] = $route;
if (null !== $name = $route->getDefault('_canonical_route')) {
$route->setDefault('_canonical_route', $prefix.$name);
}
}

$this->routes = $prefixedRoutes;
Expand Down
13 changes: 13 additions & 0 deletions src/Symfony/Component/Routing/Tests/RouteCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,4 +317,17 @@ public function testAddNamePrefix()
$this->assertNull($collection->get('foo'));
$this->assertNull($collection->get('bar'));
}

public function testAddNamePrefixCanonicalRouteName()
{
$collection = new RouteCollection();
$collection->add('foo', new Route('/foo', array('_canonical_route' => 'foo')));
$collection->add('bar', new Route('/bar', array('_canonical_route' => 'bar')));
$collection->add('api_foo', new Route('/api/foo', array('_canonical_route' => 'api_foo')));
$collection->addNamePrefix('api_');

$this->assertEquals('api_foo', $collection->get('api_foo')->getDefault('_canonical_route'));
$this->assertEquals('api_bar', $collection->get('api_bar')->getDefault('_canonical_route'));
$this->assertEquals('api_api_foo', $collection->get('api_api_foo')->getDefault('_canonical_route'));
}
}