[FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING #27272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh... Tests failed in 4.0 branch 😟 |
|
That's for branch 3.4 I suppose, the bug is there also, isn't it? |
d822599 to
b2e755e
Compare
b2e755e to
7e5fbce
Compare
chalasr
approved these changes
May 15, 2018
|
@chalasr you've renamed PR. Should I change commit description? |
|
@upyx you can, but not a requirement (the rest of the message is precise enough to not care). The reasoning behind the title change is that this change impacts FrameworkBundle only, and we use the title PR as merge commit message. |
7e5fbce to
ea5ac6a
Compare
|
I've rebased commit on head of 3.4. Tests was broken by merging 2.8 into 3.4. |
ea5ac6a to
fc9e10c
Compare
fc9e10c to
e360995
Compare
fabpot
approved these changes
May 30, 2018
|
Thank you @upyx. |
fabpot
added a commit
that referenced
this pull request
May 30, 2018
… to TYPE_BEFORE_REMOVING (upyx) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27259 | License | MIT | Doc PR | no Hello! There is fix for #27259 issue. It changes priority of `AddConsoleCommandPass` to `TYPE_BEFORE_REMOVING` as @chalasr advised. I'm not sure about side effects by that. Commits ------- e360995 [FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING
Merged
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Jun 26, 2018
…(see #1590) Description ----------- The changes in symfony/symfony#27272 broke our support for doctrine migrations support. Commits ------- 5e972d9 Fixed DoctrineMigrationsPass not working with latest Symfony 3.4+ changes anymore
ausi
pushed a commit
to contao/contao
that referenced
this pull request
Aug 15, 2018
…nymore (see #1590) Description ----------- The changes in symfony/symfony#27272 broke our support for doctrine migrations support. Commits ------- 5e972d96 Fixed DoctrineMigrationsPass not working with latest Symfony 3.4+ changes anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
There is fix for #27259 issue. It changes priority of
AddConsoleCommandPasstoTYPE_BEFORE_REMOVINGas @chalasr advised. I'm not sure about side effects by that.