[Cache] memcache connect should not add duplicate entries on sequential calls #27318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@palex-fpt why did you close ? |
|
oops. I did not notice it was added to 3.4 milestone. I thought it should be based on 3.4 branch and resubmit it. |
|
@palex-fpt no need for a new PR, we can switch the target branch while merging, but you can also do it on your side https://blog.github.com/2016-08-15-change-the-base-branch-of-a-pull-request/ (and rebase). |
…ntries on sequential calls
|
Thank you @palex-fpt. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 4, 2018
…on sequential calls (Aleksey Prilipko) This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #27318). Discussion ---------- [Cache] memcache connect should not add duplicate entries on sequential calls | Q | A | ------------- | --- | Branch? | 3.4 (be careful when merging) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #27299 | License | MIT MemcachedCache::createConnection adds server to list of servers on every call. But resets this list only when it is not empty and does not match configured list. This leads to follow: after first call list contains correct entry. After second it has server entry twice. After third it clears list and set it with correct value. With combination of libmemcached bug (segfault on adding server after reset nonempty list) it makes impossible to use MemcachedCache::createConnection to create persistent connections. Commits ------- af06990 bug #27299 [Cache] memcache connect should not add duplicate entries on sequential calls
This was referenced Jun 25, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemcachedCache::createConnection adds server to list of servers on every call. But resets this list only when it is not empty and does not match configured list.
This leads to follow: after first call list contains correct entry. After second it has server entry twice. After third it clears list and set it with correct value.
With combination of libmemcached bug (segfault on adding server after reset nonempty list) it makes impossible to use MemcachedCache::createConnection to create persistent connections.