[Messenger] Activation middleware decorator #27320
Conversation
|
How would someone use it? Manually, as in registers a service that |
|
@sroze : Exactly. It'll just leverage DI capabilities. |
| /** | ||
| * @param Envelope $message | ||
| */ | ||
| public function handle($message, callable $next) |
There was a problem hiding this comment.
PHP allows you to rename $message to $envelope here, right?
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Messenger\Middleware\Enhancers; |
There was a problem hiding this comment.
Is the Enhancers sub-namespace required? Nesting hurts discovery IMHO, better remove it?
There was a problem hiding this comment.
This was mainly echoing Symfony\Component\Messenger\Transport\Enhancers which are decorators. But of course I'm fine with removing this namespace.
There was a problem hiding this comment.
I'd keep it that way; it helps when exploring the code base I believe.
|
Thank you @ogizanagi. |
This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Activation middleware decorator | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | part of #26901 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | TODO A small middleware decorator that can be wired using DI decoration to enable/disable a middleware on an arbitrary condition. This can be used to keep the same middleware stack across env but enable/disable some of them through this. Commits ------- 6e43838 [Messenger] Activation middleware decorator
|
Is there a doc PR for this? |
|
@kbond : Not yet. Feel free to open one if you want. Otherwise it'll go in my TODO list anyway :) EDIT: I've created symfony/symfony-docs#10035 to help |
A small middleware decorator that can be wired using DI decoration to enable/disable a middleware on an arbitrary condition. This can be used to keep the same middleware stack across env but enable/disable some of them through this.