[HttpKernel] reset kernel start time on reboot #27344
Conversation
| @@ -111,6 +111,10 @@ public function __clone() | |||
| public function boot() | |||
| { | |||
| if (true === $this->booted) { | |||
| if ($this->debug) { | |||
| $this->startTime = microtime(true); | |||
| } | |||
There was a problem hiding this comment.
I would remove the initialization done currently in __clone() as this is now redundant with this one.
Also, to be consistent, what about removing the same code in __construct() and always execute the initialization when the boot() method is called?
There was a problem hiding this comment.
As a side note, there is a side effect of this change (but this was already the case as of 3.4). Before 3.4, calling boot() a second time was a no-op. As of 3.4, calling boot() a second time re-initialize the Kernel.
There was a problem hiding this comment.
@fabpot I fully agree with the first part about removing it from __clone().
My only concern is removing the time generation from __construct() and moving it totally to boot(). In standard installation I would say it's extremely unlikely that someone used the time before boot(), but should we care about possible edge-case here?
There was a problem hiding this comment.
No, I would say that it does not matter (that is internal stuff anyway). And that gives more consistent numbers between the first request and the following ones.
00cae3b to
b7feef0
Compare
|
Thank you @kiler129. |
This PR was squashed before being merged into the 3.4 branch (closes #27344). Discussion ---------- [HttpKernel] reset kernel start time on reboot | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27319 | License | MIT | Doc PR | n/a I created branch from 3.4, since the furthest thing I could find for the reboot feature was a4fc492 and it originated during stabilization phase of 3.4. ping @nicolas-grekas Commits ------- b7feef0 [HttpKernel] reset kernel start time on reboot
| @@ -110,6 +102,10 @@ public function __clone() | |||
| */ | |||
| public function boot() | |||
| { | |||
| if ($this->debug) { | |||
| $this->startTime = microtime(true); | |||
There was a problem hiding this comment.
shouldn't we do this only when we actually do something (i.e. when not booted, or when the booting again without a request stack size) ?
I created branch from 3.4, since the furthest thing I could find for the reboot feature was a4fc492 and it originated during stabilization phase of 3.4.
ping @nicolas-grekas