Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] fix deprecation in AbstractTestSessionListener #27350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alekitto
Copy link
Contributor

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

After #26564 functional tests began to emit a deprecation warning because of getSession() being called without verifying the existence of a session.

@nicolas-grekas
Copy link
Member

Thank you @alekitto.

@nicolas-grekas nicolas-grekas merged commit 0ecaefe into symfony:4.1 May 25, 2018
nicolas-grekas added a commit that referenced this pull request May 25, 2018
…r (alekitto)

This PR was merged into the 4.1 branch.

Discussion
----------

[HttpKernel] fix deprecation in AbstractTestSessionListener

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

After #26564 functional tests began to emit a deprecation warning because of `getSession()` being called without verifying the existence of a session.

Commits
-------

0ecaefe [HttpKernel] fix deprecation in AbstractTestSessionListener
@fabpot fabpot mentioned this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants