Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] cleanup generated test container #27367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Cleans up removed and hidden services, fixes an issue when the private container locator is inlined.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone May 24, 2018
@nicolas-grekas nicolas-grekas changed the title Fwb tune test container [FrameworkBundle] cleanup generated test container May 24, 2018
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you update tests to cover your changes ?

@nicolas-grekas nicolas-grekas force-pushed the fwb-tune-test-container branch from b49ae8f to d8cbec0 Compare May 24, 2018 15:31
@nicolas-grekas
Copy link
Member Author

Tests fixed.

Status: needs review

@nicolas-grekas nicolas-grekas merged commit d8cbec0 into symfony:4.1 May 25, 2018
nicolas-grekas added a commit that referenced this pull request May 25, 2018
…s-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] cleanup generated test container

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Cleans up removed and hidden services, fixes an issue when the private container locator is inlined.

Commits
-------

d8cbec0 [FrameworkBundle] cleanup generated test container
@nicolas-grekas nicolas-grekas deleted the fwb-tune-test-container branch May 25, 2018 15:27
@fabpot fabpot mentioned this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants