Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DI] do not log an inlined service as removed #27469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DI] do not log an inlined service as removed #27469

wants to merge 1 commit into from

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Jun 1, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27386
License MIT
Doc PR

This way you can actually see real unsed services that you might be able to remove or that you can exclude from the autowiring config.

Before in an app of mine:

Class Messages
Symfony\Component\DependencyInjection\Compiler\InlineServiceDefinitionsPass 875
Symfony\Component\DependencyInjection\Compiler\RemoveUnusedDefinitionsPass 985

After:

Class Messages
Symfony\Component\DependencyInjection\Compiler\InlineServiceDefinitionsPass 875
Symfony\Component\DependencyInjection\Compiler\RemoveUnusedDefinitionsPass 159

@Tobion Tobion force-pushed the do-not-log-inlined-services-twice branch from fb0751b to 835b79c Compare June 1, 2018 17:07
@Tobion Tobion force-pushed the do-not-log-inlined-services-twice branch from 835b79c to be0ea03 Compare June 1, 2018 17:09
@nicolas-grekas
Copy link
Member

I was also working on this, see #27471 :)

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 1, 2018
@nicolas-grekas
Copy link
Member

Closing in favor of #27471, thank you @Tobion.

@Tobion Tobion deleted the do-not-log-inlined-services-twice branch June 4, 2018 23:16
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection Feature Status: Needs Review
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobion @nicolas-grekas @carsonbot