[DI] Remove default env type check on validate #27470
Conversation
| 'scalar_node' => '%env(NULLED)%', | ||
| 'int_node' => '%env(int:FOO)%', | ||
| 'float_node' => '%env(float:BAR)%', | ||
| 'float_node' => '%env(FLOATISH)%', |
There was a problem hiding this comment.
currently this fails, im not sure what we expect here. Env without a prefix is now assumed to be a scalar which is not allowed for float-only node.
There was a problem hiding this comment.
shouldn't we use is_numeric() somewhere?
There was a problem hiding this comment.
It's a scalar issue in general, directly related to
im not sure what's the behavior we're seeking... what does "env without prefix" mean on its value? It if can be any scalar then using it for a float node is invalid, technically.
to make it work we should simply avoid the type check in config for this case, but it makes validation less strict.
There was a problem hiding this comment.
Would it be possible to prefix a processor here? Referencing the envelope bar with float: prepended?
There was a problem hiding this comment.
Well, the thing is, without the float cast in the env var retrieval, the service would not receive a float, but a string. So float_node not accepting %env(FLOATISH)% is expected to me.
|
bc break resolved, instead of using a string typed placeholder it now preserves the actual env type |
|
Thank you @ro0NL. |
|
Will you add any tests to prevent regressions? :D |
|
@teohhanhui what do you propose? tests are updated as such ... |
|
Sorry, I somehow overlooked that. 🙇♂️ |
|
I'm sorry, but this just broke my project and I had to spend like a few hours trying to figure out what was going on. In my config files I had stuff like: Those env-vars were defined in Upgrading Only by adding the Breaking BC like this is NOT OK, especially when incrementing only patch version !! |
|
it had to be done to prevent another BC break between 3.x and 4.x: #27455 so 4.1.0 is the wrong behavior, and fixed as of 4.1.6.. but i understand being in between was not convenient for you :( |
This PR was merged into the 4.3-dev branch. Discussion ---------- [DI] Deprecate non-string default envs | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes-ish | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes | Tests pass? | no <!-- please add some, will be required by reviewers --> | Fixed tickets | #27680, symfony/symfony#27470 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This is a failing test to further clarify the issues raised in #27680 So given symfony/symfony#27680 (comment) > We should be sure this solves a real-world issue. I think it solves a real bug :) Commits ------- 2311437c9f [DI] Deprecate non-string default envs
This PR was merged into the 4.3-dev branch. Discussion ---------- [DI] Deprecate non-string default envs | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes-ish | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes | Tests pass? | no <!-- please add some, will be required by reviewers --> | Fixed tickets | #27680, #27470 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This is a failing test to further clarify the issues raised in #27680 So given #27680 (comment) > We should be sure this solves a real-world issue. I think it solves a real bug :) Commits ------- 2311437 [DI] Deprecate non-string default envs
The default env is already validated to be a scalar or null on
get()