[Debug] Pass previous exception to FatalErrorException #27514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the travis error and can't reproduce it. Someone can help me? Thanks |
xabbuh
approved these changes
Jun 6, 2018
nicolas-grekas
approved these changes
Jun 6, 2018
fabpot
approved these changes
Jun 6, 2018
|
Thank you @pmontoya. |
fabpot
added a commit
that referenced
this pull request
Jun 6, 2018
…ontoya) This PR was merged into the 2.8 branch. Discussion ---------- [Debug] Pass previous exception to FatalErrorException | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27483 | License | MIT Add a previous parameter to FatalErrorException. Call \ErrorException with this parameter. Update parent::__constructor for inherited classes with default parameters and the new one Commits ------- 7f9780b Pass previous exception to FatalErrorException
This was referenced Jun 25, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a previous parameter to FatalErrorException.
Call \ErrorException with this parameter.
Update parent::__constructor for inherited classes with default parameters and the new one