[HttpKernel][FrameworkBundle] Turn HTTP exceptions to HTTP status codes by default#27519
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Jul 7, 2018
Merged
Conversation
5139ef9 to
d53ebbe
Compare
Member
Author
|
Status: needs review |
e6461da to
1c9fc7a
Compare
javiereguiluz
approved these changes
Jun 19, 2018
Member
javiereguiluz
left a comment
There was a problem hiding this comment.
I haven't tested it in a real app, but the code looks OK to me.
| public function testNullController() | ||
| { | ||
| $listener = new ExceptionListener(null); | ||
| $kernel = $this->getMockBuilder('Symfony\Component\HttpKernel\HttpKernelInterface')->getMock(); |
Member
There was a problem hiding this comment.
->getMockBuilder(HttpKernelInterface::class)->
chalasr
reviewed
Jun 20, 2018
| private $isTerminating = false; | ||
|
|
||
| public function __construct($controller, LoggerInterface $logger = null, $debug = false) | ||
| public function __construct($controller, LoggerInterface $logger = null, $debug = false, $charset = null, $fileLinkFormat = null) |
|
@nicolas-grekas thanks, would be cool if you would backport this to all affected versions (3.4, 4.x) |
1c9fc7a to
206be77
Compare
Member
Author
|
comments addressed thanks |
206be77 to
80b0739
Compare
Member
Author
|
more comments @symfony/deciders ? |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2018
…HTTP status codes by default (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpKernel][FrameworkBundle] Turn HTTP exceptions to HTTP status codes by default | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25844 | License | MIT | Doc PR | - When an exception is thrown, *if it is not handled* then it will be reinjected as a 2nd exception event via `HttpKernel::terminateWithException()`. When this happens, this will generate a proper HTTP status code. Commits ------- 80b0739 [HttpKernel][FrameworkBundle] Turn HTTP exceptions to HTTP status codes by default
This was referenced Nov 3, 2018
Closed
Merged
nicolas-grekas
commented
Jun 5, 2019
| if (!$event->isMasterRequest()) { | ||
| return; | ||
| } | ||
| if (!$this->isTerminating) { |
Member
Author
There was a problem hiding this comment.
for the record, the state managed by this property ensures that we don't break apps that handle exceptions outside of the stack:
try {
$kernel->handle($request);
} catch (SomeException $e) {
// ...
}as required e.g. in some framework migration strategies.
As hinted in the PR description, this allows running the fallback exception logic only when no catch block stopped the bubbling, in terminateWithException.
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jun 5, 2019
This reverts PR symfony#27519 this commit 18c2dde, reversing changes made to ac1189a.
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jun 5, 2019
This reverts PR symfony#27519 this commit 18c2dde, reversing changes made to ac1189a.
fabpot
added a commit
that referenced
this pull request
Jun 5, 2019
…las-grekas) This PR was merged into the 4.2 branch. Discussion ---------- [HttpKernel] Fix handling non-catchable fatal errors | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This reverts PR #27519 this commit 18c2dde, reversing changes made to ac1189a. Right now, the listener is skipped on fatal errors. Commits ------- a1619cc [HttpKernel] Fix handling non-catchable fatal errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception is thrown, if it is not handled then it will be reinjected as a 2nd exception event via
HttpKernel::terminateWithException(). When this happens, this will generate a proper HTTP status code.