Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] show public/private for aliases in debug:container command #27551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2018
Merged

[FrameworkBundle] show public/private for aliases in debug:container command #27551

merged 1 commit into from
Jun 19, 2018

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jun 8, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR not needed

It could be helpful to see the public/private status for aliases in debug:container command.

Otherwise you need to dive into the code to get the information, because the result only shows the options of the aliased service.

Look & Feel for public alias

screenshot 2018-06-08 09 25 50

text has slightly changed

Look & Feel for private alias

screenshot 2018-06-08 09 23 31

text has slightly changed

//cc @nicolas-grekas

@linaori
Copy link
Contributor

linaori commented Jun 8, 2018

I like this, small but useful! I noticed your screenshots mention "an public/private alias", but it's already fixed in your code (in case people notice this).

@OskarStark
Copy link
Contributor Author

OskarStark commented Jun 8, 2018 •
edited
Loading

I like this, small but useful!

Thank you 😄

I noticed your screenshots mention "an public/private alias", but it's already fixed in your code (in case people notice this).

Yes, thats what I mean by text has slightly changed below the screenshots 👍

@nicolas-grekas
Copy link
Member

CI is failing due to some console width issue, can you update the tests to force a specific width? (there are other places doing so, can't recall right now)

@chalasr chalasr added this to the next milestone Jun 8, 2018
@chalasr
Copy link
Member

chalasr commented Jun 8, 2018

Features are for master. The console width is forced there so rebasing and regenerating the fixture should make tests green.

@OskarStark
Copy link
Contributor Author

Features are for master.

Indeed, you are right, but I talked to @nicolas-grekas and we think it could be also merged as patch.
In this case we could get this from 2.8 upwards. WDYT?
But in this case we need to force the console width in this branch, too, right?

@fabpot
Copy link
Member

fabpot commented Jun 8, 2018

New features are for master only.

@OskarStark
Copy link
Contributor Author

New features are for master only.

ok I will rebase my branch 👍

@OskarStark OskarStark changed the base branch from 2.8 to master June 8, 2018 11:41
@OskarStark OskarStark changed the title [WIP] [FrameworkBundle] show public/private for aliases in debug:container command [FrameworkBundle] show public/private for aliases in debug:container command Jun 8, 2018
@OskarStark
Copy link
Contributor Author

TBH I could not get the tests running, due to whitespaces, line endings or something else.
Tried vim and PHPStorm on a MacBook 😢

@OskarStark
Copy link
Contributor Author

screenshot 2018-06-08 13 57 24

This is the problem

@chalasr chalasr self-requested a review June 16, 2018 04:59
@OskarStark
Copy link
Contributor Author

Can anybody help me finishing this PR?

I can give access to my fork too ofc

@nicolas-grekas
Copy link
Member

Tests fixed.

@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 1df7742 into symfony:master Jun 19, 2018
nicolas-grekas added a commit that referenced this pull request Jun 19, 2018
@nicolas-grekas
feature #27551 [FrameworkBundle] show public/private for aliases in d…
c694804 
…ebug:container command (OskarStark)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle] show public/private for aliases in debug:container command

| Q             | A
| ------------- | ---
| Branch?       |  master
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | not needed <!-- required for new features -->

It could be helpful to see the public/private status for aliases in `debug:container` command.

Otherwise you need to dive into the code to get the information, because the result only shows the options of the aliased service.

## Look & Feel for public alias
![screenshot 2018-06-08 09 25 50](https://user-images.githubusercontent.com/995707/41144664-f3b50766-6afd-11e8-92d0-ca30513a1afc.png)

_text has slightly changed_

## Look & Feel for private alias
![screenshot 2018-06-08 09 23 31](https://user-images.githubusercontent.com/995707/41144593-b354aad2-6afd-11e8-8ab1-f9196e567f67.png)

_text has slightly changed_

//cc @nicolas-grekas

Commits
-------

1df7742 [FrameworkBundle] show public/private for aliases in debug:container command
@OskarStark OskarStark deleted the show-public-property-for-alias branch June 19, 2018 11:05
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@OskarStark @linaori @nicolas-grekas @chalasr @fabpot @carsonbot