Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator][Form] Remove BOM in some xlf files #27630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

gautierderuette
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass?
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

I removed first blank space from some xml files

It caused this error during cache:clear
[ERROR 4] Start tag expected, '<' not found (in n/a - line 1, column 1)

@gautierderuette gautierderuette changed the title 3.4 Bug during cache clear Jun 18, 2018
@gautierderuette gautierderuette changed the title Bug during cache clear Bug during cache:clear Jun 18, 2018
@nicolas-grekas
Copy link
Member

Thank you for this PR.
By "blank space", I suppose there was a BOM before the first <?
This should be merged on branch 2.8, where the files exist also, isn't it?

@gautierderuette
Copy link
Contributor Author

You are right, it must be a BOM,
I hesitated to merge to 2.8 because I have never seen this error before.

@gautierderuette gautierderuette changed the base branch from 3.4 to 2.8 June 19, 2018 07:39
@gautierderuette gautierderuette changed the base branch from 2.8 to 3.4 June 19, 2018 07:39
@gautierderuette
Copy link
Contributor Author

Do I have to create a new pull request ?

@nicolas-grekas nicolas-grekas changed the title Bug during cache:clear [Validator][Form] Remove BOM in some xlf files Jun 19, 2018
@nicolas-grekas nicolas-grekas changed the base branch from 3.4 to 2.8 June 19, 2018 08:02
@nicolas-grekas
Copy link
Member

Good catch, thanks @gautierderuette.

@nicolas-grekas nicolas-grekas merged commit 0bc53d6 into symfony:2.8 Jun 19, 2018
nicolas-grekas added a commit that referenced this pull request Jun 19, 2018
…uette)

This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes #27630).

Discussion
----------

[Validator][Form] Remove BOM in some xlf files

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   |
| Fixed tickets | #...
| License       | MIT
| Doc PR        | symfony/symfony-docs#...

I removed first blank space from some xml files

It caused this error during cache:clear
[ERROR 4] Start tag expected, '<' not found (in n/a - line 1, column 1)

Commits
-------

0bc53d6 [Validator] Remove BOM in some xlf files
@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants