[SecurityBundle] Dont throw if "security.http_utils" is not found #27701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jun 25, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Jun 25, 2018
…t found (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Dont throw if "security.http_utils" is not found | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27445 | License | MIT | Doc PR | - The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already. Commits ------- db88330 [SecurityBundle] Dont throw if "security.http_utils" is not found
Merged
|
It looks like it reverts c003b7a, but this PR targets Symfony 3.4, while c003b7a targeted 2.7. Should it be backported to Symfony 2.7 and/or 2.8? I had the same bug when launching tests that worked 5 months ago : https://travis-ci.org/alexislefebvre/AsyncTweetsBundle/builds/398227684 is broken but the same commit tested 5 months ago didn't crash: https://travis-ci.org/alexislefebvre/AsyncTweetsBundle/builds/339996354 |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2018
…t found (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Dont throw if "security.http_utils" is not found | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27445 | License | MIT | Doc PR | - The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already. Commits ------- db88330 [SecurityBundle] Dont throw if "security.http_utils" is not found
|
@alexislefebvre you're right! 2.7 is out of maintenance, so here is the cherry-pick on 2.8: 6e5c15d |
|
You were fast, thanks @nicolas-grekas :) |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2018
* 2.8: [HttpFoundation] update phpdoc of FlashBagInterface::add() bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas) [Validator] Fix the namespace of RegexTest
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2018
* 3.4: [HttpFoundation] update phpdoc of FlashBagInterface::add() [ProxyManagerBridge] Fix support of private services (bis) bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas) [Form] relax fixtures for forward compat [Validator] Fix the namespace of RegexTest [Lock] fix locale dependent test case
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2018
* 4.0: [HttpFoundation] update phpdoc of FlashBagInterface::add() [ProxyManagerBridge] Fix support of private services (bis) bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas) [Form] relax fixtures for forward compat [Validator] Fix the namespace of RegexTest [Lock] fix locale dependent test case
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jun 29, 2018
* 4.1: [HttpFoundation] update phpdoc of FlashBagInterface::add() [ProxyManagerBridge] Fix support of private services (bis) bug symfony#27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas) [Form] relax fixtures for forward compat [Validator] Fix the namespace of RegexTest [Lock] fix locale dependent test case
|
Is a new release of 2.8 scheduled? The last version doesn't contain this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment + test were misleading, the actual important thing is wiring
AddSessionDomainConstraintPassbefore removing passes, which is already the case already.