[DependencyInjection] fix handling of empty DI extension configs #27710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 25, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27707 |
| License | MIT |
| Doc PR |
|
This will fix the issue reported in #27707. However, I am not sure if it is really a good idea to process all the |
|
lets skip those extensions / apply array_filter here: it only validates env placeholders which are not present in empty configs anyway. |
|
@ro0NL done |
chalasr
approved these changes
Jun 26, 2018
nicolas-grekas
approved these changes
Jun 28, 2018
ogizanagi
approved these changes
Jun 29, 2018
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2018
…onfigs (xabbuh) This PR was merged into the 4.1 branch. Discussion ---------- [DependencyInjection] fix handling of empty DI extension configs | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27707 | License | MIT | Doc PR | Commits ------- 05d4bcb fix handling of empty DI extension configs
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jul 10, 2018
fabpot
added a commit
that referenced
this pull request
Jul 12, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [DependencyInjection] add missing test for #27710 | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27710 (review) | License | MIT | Doc PR | Commits ------- a265caf [DependencyInjection] add missing test for #27710
fabpot
added a commit
that referenced
this pull request
Jul 16, 2018
* 4.1: fixed typo [FrameworkBundle] fixed brackets position in method calls Add placeholder support in bootstrap 4 file fields [Form] Improve rendering of `file` field in bootstrap 4 [Form] Fix PHPDoc for FormConfigBuilder $dataClass argument [Security] Update user phpdoc on tokens [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2 suppress side effects in 'get' or 'has' methods of NamespacedAttributeBag [HttpFoundation] reset callback on StreamedResponse when setNotModified() is called [HttpFoundation] Fixed phpdoc for get method of HeaderBag fix typo in ContainerBuilder docblock [Form/Profiler] Massively reducing memory footprint of form profiling pages by removing redundant 'form' variable from view variables. [Console] correctly return parameter's default value on "--" [DependencyInjection] add missing test for #27710 [EventDispatcher] Clear orphaned events on TraceableEventDispatcher::reset Fix serialization of abstract items with groups across multiple entities
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.