[HttpFoundation] fix session tracking counter #27714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4542d92 to
7569f23
Compare
7569f23 to
4419573
Compare
4419573 to
2b0beac
Compare
2b0beac to
89ed756
Compare
|
Thanks @dmaicher, I pushed the fix here also. PR ready. The session tracker was too eager. |
dunglas
approved these changes
Jun 27, 2018
|
Unfortunately the tests added in this PR are still failing... |
|
Don't be sad, that happens all the time. |
|
Thank you @dmaicher. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2018
…kas, dmaicher) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] fix session tracking counter | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - As just discussed with @nicolas-grekas I found this issue today while upgrading my app to 3.4.12. Somehow its not possible anymore to set caching headers correctly since this commit: 146e01c#diff-5350dc763df30ada9d00563c115f6652 Commits ------- 89ed756 failing test to reproduce session problem 26fc4e6 [HttpFoundation] fix session tracking counter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As just discussed with @nicolas-grekas I found this issue today while upgrading my app to 3.4.12. Somehow its not possible anymore to set caching headers correctly since this commit: 146e01c#diff-5350dc763df30ada9d00563c115f6652