Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DI] fix dumping deprecated service in yaml #27716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2018
Merged

[DI] fix dumping deprecated service in yaml #27716

merged 1 commit into from
Jun 26, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 25, 2018 •
edited
Loading

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 25, 2018
ogizanagi
ogizanagi approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for 2.8?

@nicolas-grekas nicolas-grekas changed the base branch from 3.4 to 2.8 June 26, 2018 07:59
@nicolas-grekas nicolas-grekas modified the milestones: 3.4, 2.8 Jun 26, 2018
@nicolas-grekas nicolas-grekas merged commit 411be25 into symfony:2.8 Jun 26, 2018
nicolas-grekas added a commit that referenced this pull request Jun 26, 2018
@nicolas-grekas
bug #27716 [DI] fix dumping deprecated service in yaml (nicolas-grekas)
1371b8f 
This PR was merged into the 2.8 branch.

Discussion
----------

[DI] fix dumping deprecated service in yaml

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

411be25 [DI] fix dumping deprecated service in yaml
@nicolas-grekas nicolas-grekas deleted the di-dump-deprec branch June 26, 2018 08:26
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @xabbuh @ogizanagi @carsonbot