-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] add conflict for non-compatible TwigBridge version #27719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There have been similar reports on other deps recently. I feel like we will not be able to catch up with all combinations of versions and we should instead tell people how to update. Many did update only framework-bundle, which is wrong. Doing I'd be 👎 here to not create a precedent. |
I tend to disagree. We have conflict rules "everywhere" to prevent such issues. The only reason we didn't have one here is that we don't have tests that perform some assertions on the container for this part (might be a good opportunity to add some which would also prevent further regressions). |
Tend to agree with @xabbuh. Recommending to update |
But framework-bundle doesn't know about twig-bridge. |
but it does |
that's not obvious reading the composer.json file ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(test welcome later when you have some time :) )
Thank you @xabbuh. |
…idge version (xabbuh) This PR was merged into the 4.1 branch. Discussion ---------- [FrameworkBundle] add conflict for non-compatible TwigBridge version | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27713 | License | MIT | Doc PR | The argument was dropped in #27454. Commits ------- 251e684 add conflict for non-compatible TwigBridge version
The argument was dropped in #27454.