Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] add conflict for non-compatible TwigBridge version #27719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 26, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27713
License MIT
Doc PR

The argument was dropped in #27454.

@nicolas-grekas
Copy link
Member

There have been similar reports on other deps recently. I feel like we will not be able to catch up with all combinations of versions and we should instead tell people how to update. Many did update only framework-bundle, which is wrong. Doing composer update "symfony/*" fixes the issue for everyone.

I'd be 👎 here to not create a precedent.

@xabbuh
Copy link
Member Author

xabbuh commented Jun 30, 2018

I tend to disagree. We have conflict rules "everywhere" to prevent such issues. The only reason we didn't have one here is that we don't have tests that perform some assertions on the container for this part (might be a good opportunity to add some which would also prevent further regressions).

@chalasr
Copy link
Member

chalasr commented Jun 30, 2018

Tend to agree with @xabbuh. Recommending to update symfony/* is a thing, having invalid version constraints between components is another. You taught me it @nicolas-grekas: symfony components/bundles are used in the wild, we can't assume that everyone hear and apply our recommendations, here perhaps because of their own technical constraints leading them to try updating a component and not another.
I think we should keep up improving our cross-package test coverage and maintain proper conflict rules when possible.

@nicolas-grekas
Copy link
Member

But framework-bundle doesn't know about twig-bridge.
All the other conflicts are legit because they target lower level package that framework-bundle is built on.
twig-bridge is just foreign to it.

@xabbuh
Copy link
Member Author

xabbuh commented Jul 1, 2018

but it does

@nicolas-grekas
Copy link
Member

that's not obvious reading the composer.json file ;)
you were suggesting adding a test case, possible?

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(test welcome later when you have some time :) )

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 251e684 into symfony:4.1 Jul 4, 2018
nicolas-grekas added a commit that referenced this pull request Jul 4, 2018
…idge version (xabbuh)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] add conflict for non-compatible TwigBridge version

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27713
| License       | MIT
| Doc PR        |

The argument was dropped in #27454.

Commits
-------

251e684 add conflict for non-compatible TwigBridge version
@xabbuh xabbuh deleted the issue-27713 branch July 5, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants