[WebProfilerBundle] Append new ajax request to the end of the list #27763
Conversation
|
Not sure that failed build is related to the changes... |
|
Let's ask some heavy users of Ajax requests (like @ostrolucky) what do they think of this proposal. I "remember" that in the past we did the opposite change ... but I'm not sure at all. Thanks! |
|
I don't remember this being at bottom ever |
|
@ostrolucky this behaviour was at the first (light) profiler design with symfony <=2.7 |
Before:
After:
|
|
btw, your GIF shows that you are reintroducing the behavior which was asked for removal: having to scroll to be able to see the latest requests. |
|
@stof missed that one. Is this the only reason? What about this behavior:
|
|
I think that would be best. It mimics behaviour of browser network inspectors |
|
Thank you @BoShurik. |
… of the list (BoShurik) This PR was squashed before being merged into the 4.2-dev branch (closes #27763). Discussion ---------- [WebProfilerBundle] Append new ajax request to the end of the list Append new ajax request to the end of the list instead of adding it to the beginning | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes/no | BC breaks? | no/yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Didn't find why this behavior was changed with web profiler design. In current version it is hard to click to the latest ajax request. Commits ------- 45d4559 [WebProfilerBundle] Append new ajax request to the end of the list
| @@ -177,7 +177,10 @@ | |||
| }, 100); | |||
|
|
|||
| row.className = 'sf-ajax-request sf-ajax-request-loading'; | |||
| tbody.insertBefore(row, tbody.firstChild); | |||
| tbody.insertBefore(row, null); | |||
There was a problem hiding this comment.
isn't that tbody.appendChild(row) ?
There was a problem hiding this comment.
@stof oh, missed that one. Is it worth a new PR?
Append new ajax request to the end of the list instead of adding it to the beginning
Didn't find why this behavior was changed with web profiler design.
In current version it is hard to click to the latest ajax request.