Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TwigBundle] Fixed caching of templates in default path on cache warmup #27764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

[TwigBundle] Fixed caching of templates in default path on cache warmup #27764

merged 1 commit into from
Sep 5, 2018

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jun 28, 2018 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Reproducer

$ git clone https://github.com/symfony/demo && cd demo
$ bin/console cache:clear
$ find var/cache/dev/twig -printf "%y\n" | awk '/f/{f++}/d/{d++}END{printf "%d directories, %d files\n", d, f}'
...

Before:

...
131 directories, 167 files

Twig paths config:

symfony/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php

Line 104 in 44ce4dd

$container->getDefinition('twig.template_iterator')->replaceArgument(2, $config['paths']);

%kernel.root_dir%/Resources/views:

symfony/src/Symfony/Bundle/TwigBundle/TemplateIterator.php

Line 50 in 2b01d59

$this->templates = $this->findTemplatesInDirectory($this->rootDir.'/Resources/views');

After:

...
141 directories, 193 files

Adding %twig.default_path%.

@yceruto yceruto changed the title [TwigBundle] Fix missed templates in default path on cache warmup [TwigBundle] Fixed caching of templates in default path on cache warmup Jun 28, 2018
@nicolas-grekas nicolas-grekas modified the milestones: 4.0, 3.4 Jun 29, 2018
@nicolas-grekas nicolas-grekas requested a review from stof July 9, 2018 12:44
@yceruto
Copy link
Member Author

yceruto commented Jul 13, 2018

Any update about this?

@stof do you still think this solution is wrong? what is your suggestion? thanks.

@fabpot
Copy link
Member

fabpot commented Jul 19, 2018

@stof How can we move forward on this?

@yceruto yceruto mentioned this pull request Aug 12, 2018
Closed
@yceruto
Copy link
Member Author

yceruto commented Sep 1, 2018 •
edited
Loading

Can we move forward by providing some facts?

About the issue, this is the bug reproducer (see README.md for instructions).

As for the fix: adds the missing default Twig path in TemplateIterator to find templates in this directory (to cache them later) seemed like a fast merge 2 months ago.

that's the wrong fix, because that's not the template name.

It is the template name according to the test case. There is no TwigBundle configured here, I just reuse an existing path. Also (as we know) for Twig, the template class for bundles/TwigBundle/layout.html.twig is the same as @Twig/layout.html.twig (if this is the correct template name you expect), both refer to the same filename templates/bundles/TwigBundle/layout.html.twig hence same cache key and same cache file (taking the symfony-demo project as example).

I hope this helps to unlock the status of this PR.

@stof
Copy link
Member

stof commented Sep 4, 2018

@yceruto but if you warmup the cache using bundles/TwigBundle/layout.html.twig, _self in it will refer to bundles/TwigBundle/layout.html.twig, not to @Twig/layout.html.twig (and also many error messages), which might create confusion (as the expected usage of this template is through the namespaced notation).
I actually think that the fact that our bundle-override path for template is actually a subpath of the main namespace is a drawback of the new structure (one we haven't identified earlier unfortunately) as it means these templates have 2 different names

@stof
Copy link
Member

stof commented Sep 4, 2018

an alternative might be to exclude %twig.default_path%/bundles from the locator for the main namespace (as that's a convention handled by the bundle anyway). These templates would then be located using their actual expected name.

@yceruto yceruto force-pushed the templates_cache branch 2 times, most recently from b00c63d to 245c860 Compare September 4, 2018 16:53
@yceruto
Copy link
Member Author

yceruto commented Sep 4, 2018

@stof thanks for clarifying, you're right about _self inside templates. I made the changes accordingly your last suggestion.

Sorry for the firing of reviews on rebasing.

@fabpot
Copy link
Member

fabpot commented Sep 4, 2018

@stof Can you review one last time before I merge? Thank you.

@yceruto yceruto mentioned this pull request Sep 4, 2018
Merged
@fabpot
Copy link
Member

fabpot commented Sep 5, 2018

Thank you @yceruto.

@fabpot fabpot merged commit 245c860 into symfony:3.4 Sep 5, 2018
fabpot added a commit that referenced this pull request Sep 5, 2018
@fabpot
bug #27764 [TwigBundle] Fixed caching of templates in default path on…
eaeb124 
… cache warmup (yceruto)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBundle] Fixed caching of templates in default path on cache warmup

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

**Reproducer**
```bash
$ git clone https://github.com/symfony/demo && cd demo
$ bin/console cache:clear
$ find var/cache/dev/twig -printf "%y\n" | awk '/f/{f++}/d/{d++}END{printf "%d directories, %d files\n", d, f}'
...
```
**Before:**
```bash
...
131 directories, 167 files
```
Twig `paths` config:
https://github.com/symfony/symfony/blob/44ce4dd62536037f9cea4db0146541b4ab867d34/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php#L104
`%kernel.root_dir%/Resources/views`:
https://github.com/symfony/symfony/blob/2b01d594818cf872bc481b3a1fe0210da29fab69/src/Symfony/Bundle/TwigBundle/TemplateIterator.php#L50
**After:**
```bash
...
141 directories, 193 files
```
Adding `%twig.default_path%`.

Commits
-------

245c860 Fixed caching of templates in default path on cache warmup
@yceruto yceruto deleted the templates_cache branch September 5, 2018 12:36
@yceruto yceruto mentioned this pull request Sep 6, 2018
Merged
This was referenced Sep 24, 2018
Closed
Closed
fabpot added a commit that referenced this pull request Sep 27, 2018
@fabpot
bug #28376 [TwigBundle] Fixed caching of templates in src/Resources/<…
2e85ef5 
…BundleName>/views on cache warmup (yceruto)

This PR was merged into the 2.8 branch.

Discussion
----------

[TwigBundle] Fixed caching of templates in src/Resources/<BundleName>/views on cache warmup

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Same as #27764, but in this case the convention is wrong.

Corrected according to:
https://github.com/symfony/symfony/blob/992a174470fd557e1cddccd3a35447209602aea3/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php#L165

Commits
-------

83a75f4 Caching missed templates on cache warmup
This was referenced Sep 30, 2018
Merged
Merged
@aschempp aschempp mentioned this pull request Oct 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBundle
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @fabpot @stof @nicolas-grekas @carsonbot