[VarDumper] display the signature of callables #27768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e57b1c to
728e7b7
Compare
chalasr
pushed a commit
that referenced
this pull request
Jun 29, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Form] relax fixtures for forward compat | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Required to make #27768 green. Commits ------- 2258ce4 [Form] relax fixtures for forward compat
ogizanagi
approved these changes
Jun 29, 2018
728e7b7 to
73b4ac7
Compare
fabpot
approved these changes
Jun 30, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2018
…s-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [VarDumper] display the signature of callables | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | bobthecow/psysh#218 | License | MIT | Doc PR | - E.g.  or  Commits ------- 73b4ac7 [VarDumper] display the signature of callables
|
I love that you dug up a three year old issue and fixed it :) |
|
@nicolas-grekas isn't this missing the handling of by-ref parameters and of variadic parameters when building the signature ? |
|
Answering my own question: this is already handled by |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
or