[FrameworkBundle] Moving Cache-related CompilerPass to Cache component #27770

Korbeil · 2018-06-29T11:06:31Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	yes
Deprecations?	yes
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Hi, first PR here 🎉

This is related to #27479 and a first work to move Cache-related CompilerPass out of FrameworkBundle, it allows to decouple part of the FrameworkBundle configuration classes.

Since we didn't choosed a fixed directory organization to manage theses, I actually did same as in Bundles and used DependencyInjection folder. If we do choose to follow my last comment directory organization proposal, I'll move theses CompilerPass to Framework/DependencyInjection/Compiler directory (nothing hard here).

Thanks to @DanieleGBX that helped me checking this PR and gave me some good advices !

Here is a list of all CompilerPass I moved, with related component (I also moved related tests when they were present):

Cache - CacheCollectorPass
Cache - CachePoolClearerPass
Cache - CachePoolPass
Cache - CachePoolPrunerPass

stof · 2018-06-29T11:18:04Z

This requires adding conflict rules with all older versions of the components (or updating the min version in the require key in case of mandatory requirements) in the FrameworkBundle composer.json. Otherwise, we might end up installing an older version of the component, and have it half-configured due to not running the compiler pass.

ogizanagi · 2018-06-29T14:25:24Z

src/Symfony/Component/Translation/DependencyInjection/TranslationDataCollectorPass.php

+
+        $translatorClass = $container->getParameterBag()->resolveValue($container->findDefinition('translator')->getClass());
+
+        if (!is_subclass_of($translatorClass, 'Symfony\Component\Translation\TranslatorBagInterface')) {


Could take the opportunity to use TranslatorBagInterface::class

ogizanagi · 2018-06-29T14:29:06Z

src/Symfony/Component/Translation/DependencyInjection/TranslationLoggingPass.php

+/**
+ * @author Abdellatif Ait boudad <[email protected]>
+ */
+class TranslationLoggingPass implements CompilerPassInterface


Keeping it named LoggingTranslatorPass would be more consistent with Symfony\Component\Translation\LoggingTranslator

I tried to be consistant with other CompilerPass that were already in Translation/DependencyInjection, I can move back to the old name if preferred .

lyrixx · 2018-07-03T13:17:33Z

@Korbeil you also need to remove theses line: https://github.com/symfony/symfony/blob/master/.github/CODEOWNERS#L25-L26

Korbeil · 2018-07-11T12:14:23Z

After quick talk with @nicolas-grekas I choosed to split this PR for each component

Now this one contains only moved CompilerPass for Cache component.

Korbeil · 2018-09-24T12:25:34Z

Hi @nicolas-grekas, anymore work to do here?

chalasr · 2018-09-25T10:26:00Z

src/Symfony/Component/Cache/Tests/DependencyInjection/CacheCollectorPassTest.php

@@ -9,15 +9,15 @@
 * file that was distributed with this source code.
 */

-namespace Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler;


The old test must be kept and marked as @legacy until the deprecated class is removed (same for all passes moved here)

Just reverted old tests, for @legacy you want it on all tests ?
Is it also needed on passes since we have the @deprecated tag ?

it's @group legacy on the test classes

Should be okay, tell me if I forgot something.

chalasr · 2018-09-25T12:16:28Z

...ymfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/CachePoolPrunerPassTest.php

    /**
     * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
-     * @expectedExceptionMessage Class "Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\NotFound" used for service "pool.not-found" cannot be found.
+     * @expectedExceptionMessage Class "Symfony\Component\Cache\Tests\DependencyInjection\NotFound" used for service "pool.not-found" cannot be found.


should be reverted

Was checking tests and just saw that, sorry :/

…onent

fabpot · 2018-10-10T09:39:34Z

Thank you @Korbeil.

@DanieleGBX

… Cache component (Korbeil) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Moving Cache-related CompilerPass to Cache component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Hi, first PR here 🎉 This is related to #27479 and a first work to move Cache-related CompilerPass out of `FrameworkBundle`, it allows to decouple part of the FrameworkBundle configuration classes. Since we didn't choosed a fixed directory organization to manage theses, I actually did same as in Bundles and used DependencyInjection folder. If we do choose to follow my [last comment directory organization proposal](#27479 (comment)), I'll move theses CompilerPass to `Framework/DependencyInjection/Compiler` directory (nothing hard here). Thanks to @DanieleGBX that helped me checking this PR and gave me some good advices ! Here is a list of all CompilerPass I moved, with related component (I also moved related tests when they were present): - **Cache** - CacheCollectorPass - **Cache** - CachePoolClearerPass - **Cache** - CachePoolPass - **Cache** - CachePoolPrunerPass Commits ------- 53e7040 moving Cache-related compiler pass from FrameworkBundle to Cache component

Korbeil requested a review from lyrixx as a code owner June 29, 2018 11:06

carsonbot added Status: Needs Review BC Break Deprecation labels Jun 29, 2018

Korbeil changed the title ~~Moving all component-related CompilerPass to their component~~ [FrameworkBundle] Moving all component-related CompilerPass to their component Jun 29, 2018

chalasr added this to the next milestone Jun 29, 2018

chalasr removed the BC Break label Jun 29, 2018

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 2 times, most recently from 0d7635d to 75a38fc Compare June 29, 2018 14:38

ogizanagi reviewed Jun 29, 2018

View reviewed changes

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 6 times, most recently from 3e3cbff to 3cf69f8 Compare July 9, 2018 08:02

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 2 times, most recently from 3b4e4d7 to 7c57468 Compare July 11, 2018 12:13

Korbeil changed the title ~~[FrameworkBundle] Moving all component-related CompilerPass to their component~~ [FrameworkBundle] Moving Cache-related CompilerPass to their component Jul 11, 2018

Korbeil changed the title ~~[FrameworkBundle] Moving Cache-related CompilerPass to their component~~ [FrameworkBundle] Moving Cache-related CompilerPass to Cache component Jul 11, 2018

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 3 times, most recently from e619abd to 1c8c114 Compare July 11, 2018 12:34

xabbuh added FrameworkBundle Cache labels Jul 11, 2018

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 2 times, most recently from 3dab36d to 28703e5 Compare August 17, 2018 08:44

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch from 1bfe564 to 977f17d Compare August 31, 2018 15:39

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 2 times, most recently from 530ed5d to ce556cc Compare September 20, 2018 12:02

nicolas-grekas approved these changes Sep 25, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Sep 25, 2018

chalasr requested changes Sep 25, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Sep 25, 2018

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch 4 times, most recently from d14b867 to 95f87a5 Compare September 25, 2018 12:09

chalasr reviewed Sep 25, 2018

View reviewed changes

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch from 95f87a5 to 2a81bdb Compare September 25, 2018 12:17

chalasr approved these changes Sep 25, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Sep 25, 2018

moving Cache-related compiler pass from FrameworkBundle to Cache comp…

53e7040

…onent

Korbeil force-pushed the feature/moving-compiler-pass-out-of-framework-bundle branch from 2a81bdb to 53e7040 Compare September 26, 2018 15:26

fabpot approved these changes Oct 10, 2018

View reviewed changes

fabpot merged commit 53e7040 into symfony:master Oct 10, 2018

nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018

This was referenced Nov 3, 2018

Release v4.2.0-BETA1 #29072

Closed

Release v4.2.0-BETA1 #29073

Merged

Korbeil deleted the feature/moving-compiler-pass-out-of-framework-bundle branch February 4, 2019 20:25


		$translatorClass = $container->getParameterBag()->resolveValue($container->findDefinition('translator')->getClass());

		if (!is_subclass_of($translatorClass, 'Symfony\Component\Translation\TranslatorBagInterface')) {

Uh oh!

[FrameworkBundle] Moving Cache-related CompilerPass to Cache component #27770

[FrameworkBundle] Moving Cache-related CompilerPass to Cache component #27770

Uh oh!

Conversation

Korbeil commented Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stof commented Jun 29, 2018

Uh oh!

ogizanagi Jun 29, 2018

Choose a reason for hiding this comment

Uh oh!

ogizanagi Jun 29, 2018

Choose a reason for hiding this comment

Uh oh!

Korbeil Jun 30, 2018

Choose a reason for hiding this comment

Uh oh!

lyrixx commented Jul 3, 2018

Uh oh!

Korbeil commented Jul 11, 2018

Uh oh!

Korbeil commented Sep 24, 2018

Uh oh!

chalasr Sep 25, 2018

Choose a reason for hiding this comment

Uh oh!

Korbeil Sep 25, 2018

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Sep 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Korbeil Sep 25, 2018

Choose a reason for hiding this comment

Uh oh!

chalasr Sep 25, 2018

Choose a reason for hiding this comment

Uh oh!

Korbeil Sep 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabpot commented Oct 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Korbeil commented Jun 29, 2018 •

edited

Loading

nicolas-grekas Sep 25, 2018 •

edited

Loading

Korbeil Sep 25, 2018 •

edited

Loading