[Serializer] Class discriminator and serialization groups #27773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45366ac to
c91b7af
Compare
ogizanagi
approved these changes
Jun 29, 2018
fabpot
approved these changes
Jun 30, 2018
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2018
…(sroze) This PR was merged into the 4.1 branch. Discussion ---------- [Serializer] Class discriminator and serialization groups | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27641 | License | MIT | Doc PR | ø It turns out the discriminator mapping does not work well with the serialization groups. This is fixing it (+ a little bit of cleaning in the tests). Commits ------- c91b7af Ensure the class discriminator mechanism works with serialization groups as well
|
Thank you very much. Can you say when new version of serializer with this fix will be available via composer? |
|
@voodoo-dn you can already use |
|
Thank you) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the discriminator mapping does not work well with the serialization groups. This is fixing it (+ a little bit of cleaning in the tests).