[Lock] Fix SemaphoreStoreTest on OS X #27779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jun 29, 2018
ogizanagi
commented
Jun 29, 2018
| @@ -50,13 +50,22 @@ public function testResourceRemoval() | |||
|
|
|||
| private function getOpenedSemaphores() | |||
| { | |||
| if ('Darwin' === PHP_OS) { | |||
| $lines = explode(PHP_EOL, trim(`ipcs -s`)); | |||
There was a problem hiding this comment.
Note: I don't think using LC_ALL=C as in mentioned PR would have any effect on OS X.
There was a problem hiding this comment.
Changing the locale doesn't change the ipcsoutput, fine as is to me
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Fix SemaphoreStoreTest on OS X | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27755 (review) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A As spotted in #27755 (review), for OS X. If other OS X users could give it a try (`/phpunit src/Symfony/Component/Lock/ --filter=SemaphoreStoreTest`), that would be awesome. Commits ------- 9055611 [Lock] Fix SemaphoreStoreTest on OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in #27755 (review), for OS X.
If other OS X users could give it a try (
/phpunit src/Symfony/Component/Lock/ --filter=SemaphoreStoreTest), that would be awesome.