[MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors #27801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jul 3, 2018
fabpot
requested changes
Jul 3, 2018
| 4.2.0 | ||
| ----- | ||
|
|
||
| * added `ProcessorInterface`: an optional interface to allow autoconfiguration of monolog processors |
| namespace Symfony\Bridge\Monolog\Processor; | ||
|
|
||
| /** | ||
| * An optional interface to allow autoconfiguration of monolog processors. |
… monolog processors
|
doc PR added |
fabpot
approved these changes
Jul 3, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2018
…onfiguration of monolog processors (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#9996 Using this, enabling e.g. TokenProcessor or WebProcessor just needs one line in `services.yaml`: ```yaml services: Symfony\Bridge\Monolog\Processor\TokenProcessor: ~ Symfony\Bridge\Monolog\Processor\WebProcessor: ~ ``` Commits ------- 28a4912 [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 6, 2018
…las-grekas, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Tell about ProcessorInterface in logging/processors Doc for symfony/symfony#27801 Commits ------- ad2bad9 Minor reword 0c9c90f Tell about ProcessorInterface in logging/processors
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [DI] Allow autoconfiguring bindings | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've come up with a case where we will need to inject a different service based on which interfaces a consumer service implements: injecting a different token storage for monolog processor than for everything else. Required in #27801. Commits ------- 7c29977 [DI] Allow autoconfiguring bindings
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Oct 12, 2018
fabpot
added a commit
that referenced
this pull request
Oct 13, 2018
…rface, enabling autoconfiguration of monolog processors" (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- Revert "feature #27801 [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors" This reverts commit f27c3a8, reversing changes made to 9da0454. | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - A bridge shouldn't provide interfaces to me so I submitted Seldaek/monolog#1204 instead. This PR reverts the possibility to autoconfigure processors for now, so that it could be moved to the MonologBundle instead. To have TokenProcessor and WebProcessor classes implement the new ProcessorInterface, we could bump the minimum version of monolog. This cannot be done until a new version of it is tagged, so we need to resolve this before tagging 4.2 ourselves. Commits ------- cfc3f25 Revert "feature #27801 [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors (nicolas-grekas)"
This was referenced Nov 3, 2018
Closed
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 9, 2018
This PR was merged into the master branch. Discussion ---------- [Monolog] Move ProcessorInterface to Monolog Since symfony/symfony#27801 was reverted in symfony/symfony#28845 and the new plan being to make this interface part of Monolog. Commits ------- 663f2ea [Monolog] Move ProcessorInterface to Monolog
lyrixx
reviewed
Nov 11, 2018
| * | ||
| * @author Nicolas Grekas <[email protected]> | ||
| */ | ||
| interface ProcessorInterface |
There was a problem hiding this comment.
Funny, for twig you forced me to add this interface in twig itself.
Why didn't you do the same thing here?
There was a problem hiding this comment.
I did, see #28845
This has been reverted and added to Monolog meanwhile :)
|
Hello, I'm a bit lost. This PR have been reverted, and some code has been move to monolog. More over the docs has not been reverted symfony/symfony-docs#9996 on https://symfony.com/doc/current/logging/processors.html
But this version does not exist. Finally, This feature does not work. I don't know what is intended here. |
|
See symfony/monolog-bundle#285 which isn't merged yet but should. |
|
@lyrixx see symfony/symfony-docs#10796 for the documentation update |
lyrixx
added a commit
to symfony/monolog-bundle
that referenced
this pull request
May 16, 2019
This PR was merged into the 3.x-dev branch. Discussion ---------- Register processors for autoconfiguration Replaces symfony/symfony#27801 (which has been reverted meanwhile) Leverages Seldaek/monolog#1204 Already documented in symfony/symfony-docs#9996 (but doc needs update) Commits ------- 7fdda67 Register processors for autoconfiguration
dani-danigm
pushed a commit
to dani-danigm/monolog-bundle
that referenced
this pull request
Jun 15, 2022
This PR was merged into the 3.x-dev branch. Discussion ---------- Register processors for autoconfiguration Replaces symfony/symfony#27801 (which has been reverted meanwhile) Leverages Seldaek/monolog#1204 Already documented in symfony/symfony-docs#9996 (but doc needs update) Commits ------- 84c0564 Register processors for autoconfiguration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this, enabling e.g. TokenProcessor or WebProcessor just needs one line in
services.yaml: