Added new methods submitForm and clickLink to Client class #27807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaori
suggested changes
Jul 2, 2018
| $client->setNextResponse(new Response('<html><form action="/foo"><input type="submit" value="Register" /></form></html>')); | ||
| $client->request('GET', 'http://www.example.com/foo/foobar'); | ||
|
|
||
| $client->submitForm('Register', array(), 'POST'); |
There was a problem hiding this comment.
I think it would be nice to add a test case where actual values are submitted along, this case is not covered right now.
|
@iltar Please review that applied changes are suitable. |
|
Added test looks good to me 👍 |
|
I think we also tests for when the link/form is not found. |
|
@fabpot |
fabpot
approved these changes
Jul 12, 2018
11bbed3 to
e098edd
Compare
|
Thank you @nowiko. |
fabpot
added a commit
that referenced
this pull request
Jul 12, 2018
…lass (nowiko) This PR was squashed before being merged into the 4.2-dev branch (closes #27807). Discussion ---------- Added new methods submitForm and clickLink to Client class | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Added new methods to BrowserKit/Client to simplify work with links and forms. Related to #27627 Commits ------- e098edd Added new methods submitForm and clickLink to Client class
This was referenced Jul 15, 2018
fabpot
added a commit
that referenced
this pull request
Jul 18, 2018
…itForm() methods (javiereguiluz) This PR was squashed before being merged into the 4.2-dev branch (closes #27956). Discussion ---------- Added types and tweaked PHPdoc of clickLink() and submitForm() methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - I wanted to suggest these changes to #27807 but I failed to do that before it was merged. Commits ------- be9d578 Added types and tweaked PHPdoc of clickLink() and submitForm() methods
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 18, 2018
This PR was squashed before being merged into the master branch (closes #10071). Discussion ---------- Added docs for clickLink() and submitForm() This documents symfony/symfony#27807 Commits ------- 0668ccc Added docs for clickLink() and submitForm()
|
these 2 methods will trigger a fatal error if you call them before calling |
symfony-splitter
pushed a commit
to symfony/browser-kit
that referenced
this pull request
Sep 29, 2018
…(xabbuh) This PR was merged into the 4.2-dev branch. Discussion ---------- [BrowserKit] throw exception when request() wasn't called | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony#27807 (comment) Commits ------- 41cfde19f6 throw exception when request() wasn't called
nicolas-grekas
added a commit
that referenced
this pull request
Sep 29, 2018
…(xabbuh) This PR was merged into the 4.2-dev branch. Discussion ---------- [BrowserKit] throw exception when request() wasn't called | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | #27807 (comment) Commits ------- 41cfde1 throw exception when request() wasn't called
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new methods to BrowserKit/Client to simplify work with links and forms.
Related to #27627