[HttpFoundation] Fix tests: new message for status 425 #27809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,7 +169,7 @@ class Response | |||
| 422 => 'Unprocessable Entity', // RFC4918 | |||
| 423 => 'Locked', // RFC4918 | |||
| 424 => 'Failed Dependency', // RFC4918 | |||
| 425 => 'Reserved for WebDAV advanced collections expired proposal', // RFC2817 | |||
| 425 => 'Too Early', // RFC-ietf-httpbis-replay-04 | |||
There was a problem hiding this comment.
I guess we also need to add a new constant above:
const HTTP_TOO_EARLY = 425;and leave the old one to maintain BC:
const HTTP_RESERVED_FOR_WEBDAV_ADVANCED_COLLECTIONS_EXPIRED_PROPOSAL = 425;There was a problem hiding this comment.
Done, I also deprecated the old const.
f188073 to
1053cbf
Compare
fabpot
approved these changes
Jul 3, 2018
1053cbf to
8e37d77
Compare
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2018
…nglas) This PR was squashed before being merged into the 2.8 branch (closes #27809). Discussion ---------- [HttpFoundation] Fix tests: new message for status 425 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a Makes tests green. The new meaning of 425 is defined here: https://datatracker.ietf.org/doc/draft-ietf-httpbis-replay/?include_text=1 Commits ------- 8e37d77 [HttpFoundation] Fix tests: new message for status 425
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes tests green.
The new meaning of 425 is defined here: https://datatracker.ietf.org/doc/draft-ietf-httpbis-replay/?include_text=1