Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow no auto caching by adding special header #27814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

guillaumedebeauvoir
Copy link

Add same fix as for version 4

Q A
Branch? master for features / 2.8 up to 4.1 for bug fixes
Bug fix? yes/no
New feature? yes/no
BC breaks? no
Deprecations? yes/no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Add same fix as for version 4
@guillaumedebeauvoir
Copy link
Author

@fabpot @nicolas-grekas what do you think of this PR? kind of need this quickly as my response time on my sites has been multiplied by 10 since the upgrade to 3.4.* =D - if not, i need to find a way around before upgrading to sf4

@nicolas-grekas
Copy link
Member

Hello @guillaumedebeauvoir thanks for the PR.
This is a new feature, so cannot go on 4.1
See https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/435/files for a solution that works on 3.4.

@guillaumedebeauvoir
Copy link
Author

@nicolas-grekas thanks for the feedback, i will have a look at foshttpcache then, my first PR rejected ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants