[MonologBridge] Prefer PSR-3 to interact with Monolog in tests #27882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 7, 2018
|
Why on 3.4 and not on master btw? |
PSR-3 should be the recommended way to interact with the logger in Monolog 1 already. Also, the tests don't differ much between 3.4 and master yet, so I thought it might be easier for the maintenance if I apply the change here. But I can rebase to master, if you want me to. |
|
Let's go on master, these tests are fine for 3.4 IMHO. |
20uf
approved these changes
Jul 8, 2018
17f8f7d to
78498d3
Compare
|
✅ Rebased to master. |
xabbuh
approved these changes
Jul 9, 2018
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
… tests (derrabus) This PR was merged into the 4.2-dev branch. Discussion ---------- [MonologBridge] Prefer PSR-3 to interact with Monolog in tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | part of #27857 | License | MIT | Doc PR | N/A This PR changes tests in the Monolog bridge: * Calls to `Logger::addInfo()` are changed to `Logger::info()`. * The return value of `Logger::debug()`, `Logger::info()`, `Logger::notice()`, `Logger::warning()`, `Logger::error()` etc. is no longer asserted to be `true`. This way, the tests only use PSR-3 compatible code to interact with the logger, which makes them forward-compatible with the changes in Monolog 2. Commits ------- 78498d3 Prefer PSR-3 to interact with Monolog in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes tests in the Monolog bridge:
Logger::addInfo()are changed toLogger::info().Logger::debug(),Logger::info(),Logger::notice(),Logger::warning(),Logger::error()etc. is no longer asserted to betrue.This way, the tests only use PSR-3 compatible code to interact with the logger, which makes them forward-compatible with the changes in Monolog 2.