Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Removed .form-control-label class. #27886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

vudaltsov
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

There is no such a class neither in bootstrap 4.0 nor in bootstrap 4.1.

@nicolas-grekas
Copy link
Member

lowest deps need a bump so that tests pass

@vudaltsov
Copy link
Contributor Author

@nicolas-grekas , is it now correct? Or high should also pass?

@xabbuh
Copy link
Member

xabbuh commented Jul 9, 2018

@vudaltsov The deps=high build is allowed to fail on PRs if the failure is related to a bump in cross-component dependencies (like in this PR).

@nicolas-grekas
Copy link
Member

Thank you @vudaltsov.

@nicolas-grekas nicolas-grekas merged commit cb3e712 into symfony:3.4 Jul 9, 2018
nicolas-grekas added a commit that referenced this pull request Jul 9, 2018
This PR was squashed before being merged into the 3.4 branch (closes #27886).

Discussion
----------

[Form] Removed .form-control-label class.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

There is no such a class neither in [bootstrap 4.0](https://getbootstrap.com/docs/4.0/components/forms/#form-controls) nor in [bootstrap 4.1](https://getbootstrap.com/docs/4.1/components/forms/#form-controls).

Commits
-------

cb3e712 [Form] Removed .form-control-label class.
@vudaltsov vudaltsov deleted the form-control-label branch December 14, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants