[Form] Removed .mb-0 in errors. #27887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lowest deps need a bump so that tests pass |
|
Isn't it strange that we have templates in one library and abstract tests for these templates in another? |
ef25445 to
44ce40a
Compare
|
@xabbuh , now all tests pass except for |
xabbuh
approved these changes
Jul 9, 2018
44ce40a to
925dda1
Compare
|
Thank you @vudaltsov. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Removed .mb-0 in errors. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `<span class="d-block">` will never have a margin on its own, so `.mb-0` is needless. Commits ------- 925dda1 Removed .mb-0 in errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<span class="d-block">will never have a margin on its own, so.mb-0is needless.