[Filesystem] fix lock file permissions #27904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 9, 2018
| @@ -77,7 +77,7 @@ public function lock($blocking = false) | |||
|
|
|||
| if (!$this->handle = fopen($this->file, 'r+') ?: fopen($this->file, 'r')) { | |||
| if ($this->handle = fopen($this->file, 'x')) { | |||
| chmod($this->file, 0444); | |||
| chmod($this->file, 0666); | |||
There was a problem hiding this comment.
btw, what about 644 here?
e3f1db7 to
7a68fea
Compare
|
Thank you @fritzmg. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
This PR was squashed before being merged into the 2.8 branch (closes #27904). Discussion ---------- [Filesystem] fix lock file permissions | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | see linked discussion | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See #27903 Commits ------- 7a68fea [Filesystem] fix lock file permissions
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #27903