[HttpFoundation] reset callback on StreamedResponse when setNotModified() is called #27937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rubencm
commented
Jul 13, 2018
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27924 |
| License | MIT |
| Doc PR | No |
fabpot
approved these changes
Jul 13, 2018
|
Thank you @rubencm. |
fabpot
added a commit
that referenced
this pull request
Jul 13, 2018
…etNotModified() is called (rubencm) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] reset callback on StreamedResponse when setNotModified() is called | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27924 | License | MIT | Doc PR | No Commits ------- 51a49c7 [HttpFoundation] reset callback on StreamedResponse when setNotModified() is called
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Sep 18, 2018
…Modified() (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] don't override StreamedResponse::setNotModified() | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Alternative implementation to #27937, because `Response::setNotModified()` has been made final in 4.0 so we shouldn't override it. Commits ------- 9ef7f70 [HttpFoundation] don't override StreamedResponse::setNotModified()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.