Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Add type declarations to Security util #27944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Security] Add type declarations to Security util #27944

wants to merge 2 commits into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jul 13, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

@chalasr chalasr added this to the next milestone Jul 13, 2018
@ro0NL ro0NL mentioned this pull request Jul 13, 2018
Merged
@fabpot
Copy link
Member

fabpot commented Jul 15, 2018

Not sure if it makes sense to merge a PR that modifies only one file (I mean, for these kind of changes).

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 15, 2018

Agree, I cherry picked this class :) Also with the direction #27943 is heading Security::getUser is blocked from types anyway

@ro0NL ro0NL closed this Jul 15, 2018
@ro0NL ro0NL deleted the patch-3 branch July 15, 2018 08:51
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vudaltsov vudaltsov vudaltsov approved these changes

Assignees
No one assigned
Labels
Feature Security Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ro0NL @fabpot @vudaltsov @nicolas-grekas @chalasr @carsonbot