Added types and tweaked PHPdoc of clickLink() and submitForm() methods #27956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jul 15, 2018
| */ | ||
| public function submitForm($button, $values, $method) | ||
| public function submitForm(string $button, array $fieldValues, string $method = 'POST'): Crawler |
There was a problem hiding this comment.
What about having array() as the default value for $fieldValues?
There was a problem hiding this comment.
I like that! Done!
|
Should we add to |
|
Might be nice. |
fabpot
approved these changes
Jul 18, 2018
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jul 18, 2018
…itForm() methods (javiereguiluz) This PR was squashed before being merged into the 4.2-dev branch (closes #27956). Discussion ---------- Added types and tweaked PHPdoc of clickLink() and submitForm() methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - I wanted to suggest these changes to #27807 but I failed to do that before it was merged. Commits ------- be9d578 Added types and tweaked PHPdoc of clickLink() and submitForm() methods
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to suggest these changes to #27807 but I failed to do that before it was merged.