Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] Fixed templateExists on parse error of the template name #28005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2018
Merged

[HttpKernel] Fixed templateExists on parse error of the template name #28005

merged 1 commit into from
Jul 23, 2018

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jul 19, 2018 •
edited
Loading

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28001
License MIT
Doc PR -

symfony/src/Symfony/Bundle/FrameworkBundle/Templating/TemplateNameParser.php

Lines 49 to 51 in 9bfa971

if (false !== strpos($name, '..')) {
throw new \RuntimeException(sprintf('Template name "%s" contains invalid characters.', $name));
}

@yceruto yceruto mentioned this pull request Jul 19, 2018
Closed
@yceruto yceruto force-pushed the fix_template_exists branch from f7c95ac to 0120979 Compare July 19, 2018 17:00
@yceruto yceruto changed the title [HttpKernel] Fixed templateExists on parse or normalization error of the template name [HttpKernel] Fixed templateExists on parse error of the template name Jul 19, 2018
@yceruto yceruto force-pushed the fix_template_exists branch 2 times, most recently from 9b0bed8 to 5ac466b Compare July 19, 2018 17:10
@yceruto yceruto force-pushed the fix_template_exists branch 2 times, most recently from 0d86c2d to 53347c4 Compare July 19, 2018 18:20
@yceruto
Copy link
Member Author

yceruto commented Jul 19, 2018 •
edited
Loading

The Twig error "malformed template name" on $loader->exists(template) should be fixed in twigphp/Twig#2721

@fabpot
Copy link
Member

fabpot commented Jul 23, 2018

Thank you @yceruto.

@fabpot fabpot merged commit 53347c4 into symfony:2.8 Jul 23, 2018
fabpot added a commit that referenced this pull request Jul 23, 2018
@fabpot
bug #28005 [HttpKernel] Fixed templateExists on parse error of the te…
b2ec4aa 
…mplate name (yceruto)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel] Fixed templateExists on parse error of the template name

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28001
| License       | MIT
| Doc PR        | -

https://github.com/symfony/symfony/blob/9bfa971bc5662a6f90408b58a7b2453d7dae4f83/src/Symfony/Bundle/FrameworkBundle/Templating/TemplateNameParser.php#L49-L51

Commits
-------

53347c4 Fixed templateExists on parse error of the template name
@fabpot fabpot mentioned this pull request Jul 23, 2018
Merged
@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Jul 23, 2018
@yceruto yceruto deleted the fix_template_exists branch July 23, 2018 14:00
This was referenced Jul 23, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@yceruto @fabpot @nicolas-grekas @carsonbot