[HttpFoundation] fixed using _method parameter with invalid type #28080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jul 27, 2018
| $request = new Request(); | ||
| $request->setMethod('POST'); | ||
| $request->query->set('_method', array('delete', 'patch')); | ||
| $this->assertEquals('POST', $request->getMethod(), '->getMethod() returns the request method if invalid type is defined in query'); |
There was a problem hiding this comment.
@xabbuh
Sorry, I just copied that from the assertion above to make no mistake. Thanks for the hint.
Should I fix this only for my new assertion or also for the others? Or should this be done in a different ticket?
There was a problem hiding this comment.
changing it just here is okay IMO
xabbuh
approved these changes
Jul 27, 2018
javiereguiluz
approved these changes
Jul 27, 2018
| @@ -1276,7 +1276,10 @@ public function getMethod() | |||
| if ($method = $this->headers->get('X-HTTP-METHOD-OVERRIDE')) { | |||
| $this->method = strtoupper($method); | |||
| } elseif (self::$httpMethodParameterOverride) { | |||
| $this->method = strtoupper($this->request->get('_method', $this->query->get('_method', 'POST'))); | |||
| $method = $this->request->get('_method', $this->query->get('_method', 'POST')); | |||
| if (\is_string($method)) { | |||
There was a problem hiding this comment.
what should happen when a non-string is found here?
returning it as is looks strange, isn't it? it break the method's signature somehow.
There was a problem hiding this comment.
In that case it would keep the current request method ("POST") because the override value is not valid. Sounds consistant to me.
nicolas-grekas
approved these changes
Jul 28, 2018
|
Thank you @Phobetor. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 29, 2018
…d type (Phobetor) This PR was squashed before being merged into the 2.8 branch (closes #28080). Discussion ---------- [HttpFoundation] fixed using _method parameter with invalid type | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28079 | License | MIT | Doc PR | - This change makes sure that an incoming `_method` parameter is only used when it is a string value. Commits ------- 63583de [HttpFoundation] fixed using _method parameter with invalid type
This was referenced Aug 1, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that an incoming
_methodparameter is only used when it is a string value.