link helper does not link Contracts #28095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jul 31, 2018
|
failing build caused by |
| @@ -42,6 +42,8 @@ $directories = array_merge(...array_values(array_map(function ($part) { | |||
| return glob(__DIR__.'/src/Symfony/'.$part.'/*', GLOB_ONLYDIR | GLOB_NOSORT); | |||
| }, $braces))); | |||
|
|
|||
| $directories[] = __DIR__.'/src/Symfony/Contracts'; | |||
There was a problem hiding this comment.
should be listed in the $braces array instead for consistency
nicolas-grekas
approved these changes
Jul 31, 2018
|
Thank you @oleg-andreyev. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 1, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- link helper does not link Contracts | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT `link` is great tool in development and while working on another PR, noticed that all `symfony/*` packages are linked except `symfony/contracts` After this PR this issue will be fixed. Commits ------- 7c124c4 appending root of Contracts dir (where composer.json is located)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkis great tool in development and while working on another PR, noticed that allsymfony/*packages are linked exceptsymfony/contractsAfter this PR this issue will be fixed.