[Cache] make PhpMarshaller handle hard references #28188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed9fada to
8f8b6b9
Compare
|
PR is green and ready. |
stof
reviewed
Aug 13, 2018
| * | ||
| * @internal | ||
| */ | ||
| public static function marshall($values, $objectsPool, &$refsPool, &$objectsCount, &$valuesAreStatic) |
There was a problem hiding this comment.
See above:
For performance this method is public and has no type-hints.
Since this method (and class) is internal, we can do it.
|
What is the goal of extracting the Marshaller class out of PhpMarshaller ? This makes review harder (as it is much harder to see which code was changed when moving it) and I don't see any usage out of PhpMarshaller |
|
The goal is allowing extra performance by making the old "doMarshall" method public and type-hint-less (see my reply to your previous comment.) |
c91729f to
69c5e8e
Compare
69c5e8e to
bc5d208
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 19, 2018
…-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] make PhpMarshaller handle hard references | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR makes the interface and behavior of `PhpMarshaller` cleaner and bullet-proof. While a bug fix at this stage, I'd like to propose splitting it to a new `VarExporter` component all goes well. Commits ------- bc5d208 [Cache] make PhpMarshaller handle hard references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the interface and behavior of
PhpMarshallercleaner and bullet-proof.While a bug fix at this stage, I'd like to propose splitting it to a new
VarExportercomponent all goes well.