[DI] Allow autowiring by type + parameter name #28234
Conversation
e448897 to
27b52c5
Compare
|
Now with a new |
There was a problem hiding this comment.
I love this. It solves the last weird autowiring situation in an automated way: classes that have multiple services (cache, log, etc).
We'll need to update debug:autowiring to show this. We want to update it anyways to be a bit more "helpful" in general. We need to do that for 4.2.
| @@ -1613,6 +1623,8 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con | |||
|
|
|||
| $definition->addTag('cache.pool', $pool); | |||
| $container->setDefinition($name, $definition); | |||
| $container->registerAliasForArgument($name, CacheInterface::class); | |||
| $container->registerAliasForArgument($name, CacheItemPoolInterface::class); | |||
There was a problem hiding this comment.
Will this work ok for the $name = '.'.$name.'.inner'; cases above?
There was a problem hiding this comment.
good catch, moved up in the foreach!
| /** | ||
| * Registers an alias for autowiring the passed id using named arguments. | ||
| */ | ||
| public function registerAliasForArgument(string $id, string $type, string $name = null): Alias |
There was a problem hiding this comment.
Can we doc the arguments? Because we normalize them into lower-camel case, I think it IS worth saying what each argument means
There was a problem hiding this comment.
I added a docblock description, good enough?
27b52c5 to
414e25a
Compare
414e25a to
82adeb1
Compare
| @@ -1509,6 +1517,8 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder | |||
| if ($busId === $config['default_bus']) { | |||
| $container->setAlias('message_bus', $busId)->setPublic(true); | |||
| $container->setAlias(MessageBusInterface::class, $busId); | |||
| } else { | |||
| $container->registerAliasForArgument($busId, MessageBusInterface::class); | |||
There was a problem hiding this comment.
Any reason why we wouldn't register every bus, including the one that has been chosen as the default? The question also works for the lock (because in cache, all of them or registered)
There was a problem hiding this comment.
Yes: because the default service is already the one wired... by default :)
|
I really like it! |
82adeb1 to
c0b8f53
Compare
done as |
…s-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [DI] Allow autowiring by type + parameter name | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10206 In #27165, we introduced the possibility to bind by type+name: ```yaml bind: Psr\Log\LoggerInterface $myLogger: @monolog.logger.my_logger ``` But we forgot about aliases. For consistency, they could and should allow doing the same. More importantly, this will open up interesting use cases where bundles could provide default values for typed+named arguments (using the new `ContainerBuilder::registerAliasForArgument()` method). E.g: ```yaml services: Psr\Cache\CacheItemPoolInterface $appCacheForecast: @app.cache.forecast ``` Works also for controller actions and service subscribers (using the real service id as the key). Commits ------- c0b8f53 [DI] Allow autowiring by type + parameter name
…rvices and their description (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] make debug:autowiring list useful services and their description | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27207 | License | MIT | Doc PR | - This PR closes #27207: we don't need "semantics" anymore. 4.2 has everything already to allow us to separate useful services from the other ones: any autowireable *alias* **is** a useful service! Add autowiring by type + parameter name (#28234) and the story is done: we can easily hint people about which features their bundles provide, without being polluted by for-wiring-only services. Here is a screenshot running this command(before I excluded the aliases for $cacheApp and $cacheSystem):  ping @weaverryan as we drafted that together. Fixes a few issues found meanwhile. That should definitely go in 4.2. Commits ------- 56aab09 [FrameworkBundle] make debug:autowiring list useful services and their description
In #27165, we introduced the possibility to bind by type+name:
But we forgot about aliases. For consistency, they could and should allow doing the same. More importantly, this will open up interesting use cases where bundles could provide default values for typed+named arguments (using the new
ContainerBuilder::registerAliasForArgument()method). E.g:Works also for controller actions and service subscribers (using the real service id as the key).