[Cache] improve perf when using RedisCluster by reducing roundtrips to the servers #28269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
380fc45 to
b48dc34
Compare
|
Do you have some benchmark ? |
|
Yes: https://blackfire.io/profiles/compare/8faaebbb-ced2-49e2-a043-ac9d6361d97e/graph
From 1.6s to 1.4s on a simple multifetch done 10k times (Blackfire disabled). |
b48dc34 to
5155f48
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 31, 2018
… roundtrips to the servers (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] improve perf when using RedisCluster by reducing roundtrips to the servers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Improves perf when using RedisCluster by: - disabling versioning and replacing by per-master clear/flush - grouping multiple "get" in one "mget" - enabling pipelining in PredisCluster mode ~Might need adjustment depending on the answer to predis/predis#520 Commits ------- 5155f48 [Cache] improve perf when using RedisCluster by reducing roundtrips to the servers
andrerom
pushed a commit
to andrerom/symfony
that referenced
this pull request
Mar 11, 2019
…e servers This is slimmed down version of: symfony#28269 _(many of the fixes here are already part of 3.4)_ Adds: - Test coverage for Predis with RedisCluster - Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases
andrerom
pushed a commit
to andrerom/symfony
that referenced
this pull request
Mar 11, 2019
…e servers This is slimmed down version of: symfony#28269 _(many of the fixes here are already part of 3.4)_ Adds: - Test coverage for Predis with RedisCluster - Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases
andrerom
pushed a commit
to andrerom/symfony
that referenced
this pull request
Mar 11, 2019
…e servers This is slimmed down version of: symfony#28269 _(many of the fixes here are already part of 3.4)_ Adds: - Test coverage for Predis with RedisCluster - Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases
nicolas-grekas
added a commit
that referenced
this pull request
Mar 13, 2019
…trips to the servers (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This is slimmed down version of: #28269 _(many of the fixes there are already part of 3.4)_ Does: - Adds test coverage for Predis with RedisCluster - Removes usage of key versioning when on RedisCluster, besides performance aspect of that it simplifies / aligning clear() handling across all clients - reuse doDelete() from clear to make sure we call singular del calls when in predis cluster Commits ------- dacf179 [Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Mar 13, 2019
…e servers This is slimmed down version of: symfony/symfony#28269 _(many of the fixes here are already part of 3.4)_ Adds: - Test coverage for Predis with RedisCluster - Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves perf when using RedisCluster by:
Might need adjustment depending on the answer to predis/predis#520