[Messenger] Only subscribe to a given bus from the MessageSubscriber #28275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fc6879 to
62a44e7
Compare
nicolas-grekas
approved these changes
Aug 27, 2018
62a44e7 to
e27885d
Compare
e27885d to
f60e409
Compare
|
@nicolas-grekas good point, I've added this scenario in a test 👌 |
chalasr
approved these changes
Aug 28, 2018
sroze
added a commit
that referenced
this pull request
Aug 28, 2018
…sageSubscriber (sroze) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Only subscribe to a given bus from the MessageSubscriber | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | ø #27275 introduced the ability to listen to only a few buses from the handler tag. This adds that ability directly from the message subscriber. It has also highlighted to me that most of the configuration can be done using `yield` (like the example I've added in this PR's tests) and that we could remove the support for other ways (especially the obscure `return [['method', -10]]` syntax) but I believe this should be done **in another pull-request** (that I'm happy to do after this one). Commits ------- f60e409 Only subscribe to a given bus from the MessageSubscriber
fabpot
added a commit
that referenced
this pull request
Aug 29, 2018
…nfiguration (sroze) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Remove the "obscure" message subscriber configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø As described in #28275, all of the configuration can be done using yield and that we could remove the support for other ways (especially the obscure return `[['method', -10]]` syntax) as I believe this would clarify the configuration a lot. Commits ------- cf2ad86 Remove the "obscure" message subscriber configuration
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27275 introduced the ability to listen to only a few buses from the handler tag. This adds that ability directly from the message subscriber.
It has also highlighted to me that most of the configuration can be done using
yield(like the example I've added in this PR's tests) and that we could remove the support for other ways (especially the obscurereturn [['method', -10]]syntax) but I believe this should be done in another pull-request (that I'm happy to do after this one).