[Serializer] Update changelog about the new $encoderIgnoredNodeTypes arg in XmlEncoder contrustor #28281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maidmaid
commented
Aug 27, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27926 |
| License | MIT |
| Doc PR | / |
dunglas
reviewed
Aug 27, 2018
| @@ -6,6 +6,7 @@ CHANGELOG | |||
|
|
|||
| * `AbstractNormalizer::handleCircularReference` is now final, and receives two optional extra arguments: the format and the context | |||
| * added support for XML comment encoding (encoding `['#comment' => ' foo ']` results `<!-- foo -->`) | |||
| * added optional `int[] $encoderIgnoredNodeTypes` argument to `XmlEncoder::__construct`. | |||
There was a problem hiding this comment.
... to configure node types to be ignored during encodage?
There was a problem hiding this comment.
Yes, better. Done !
19aee3d to
f13b2c9
Compare
| @@ -6,6 +6,8 @@ CHANGELOG | |||
|
|
|||
| * `AbstractNormalizer::handleCircularReference` is now final, and receives two optional extra arguments: the format and the context | |||
| * added support for XML comment encoding (encoding `['#comment' => ' foo ']` results `<!-- foo -->`) | |||
| * added optional `int[] $encoderIgnoredNodeTypes` argument to `XmlEncoder::__construct` to configure node types to be | |||
| ignored during encodage. | |||
There was a problem hiding this comment.
Done (\cc @dunglas 😄)
f13b2c9 to
584785a
Compare
584785a to
49f3bfc
Compare
fabpot
approved these changes
Aug 27, 2018
|
Thank you @maidmaid. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2018
…redNodeTypes arg in XmlEncoder contrustor (maidmaid) This PR was merged into the 4.2-dev branch. Discussion ---------- [Serializer] Update changelog about the new $encoderIgnoredNodeTypes arg in XmlEncoder contrustor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27926 | License | MIT | Doc PR | / Commits ------- 49f3bfc Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.