[Serializer] Add support for ignoring comments while XML encoding #28289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 30, 2018
fabpot
approved these changes
Aug 30, 2018
|
Thank you @maidmaid. |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2018
…ML encoding (maidmaid) This PR was merged into the 4.2-dev branch. Discussion ---------- [Serializer] Add support for ignoring comments while XML encoding | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / In addition to #27926 which allowed to ignore XML processing instructions, this PR allows to ignore the XML comments while encoding. Commits ------- 8f8230a Add support for ignoring comments while XML encoding
|
I've created symfony/symfony-docs#10277 to document this new feature. Please, don't forget to create a doc issue for every new feature. @maidmaid we have lots of pending doc issues about Serializer, so it would be great if you could help us submitting the docs for this new feature. Thanks! |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #27926 which allowed to ignore XML processing instructions, this PR allows to ignore the XML comments while encoding.