[Messenger] Remove the "obscure" message subscriber configuration #28294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Aug 29, 2018
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Aug 29, 2018
…nfiguration (sroze) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] Remove the "obscure" message subscriber configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø As described in #28275, all of the configuration can be done using yield and that we could remove the support for other ways (especially the obscure return `[['method', -10]]` syntax) as I believe this would clarify the configuration a lot. Commits ------- cf2ad86 Remove the "obscure" message subscriber configuration
|
I've created symfony/symfony-docs#10278 to document this new feature. Please, don't forget to create a doc issue for every new feature. The Messenger component docs are not great yet, so I don't know if this was documented and we need to change it or it was never documented and need to add it. Thanks! |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #28275, all of the configuration can be done using yield and that we could remove the support for other ways (especially the obscure return
[['method', -10]]syntax) as I believe this would clarify the configuration a lot.