[Process] Add relative path support for PHP_BINARY env var of PhpExecutableFinder #28303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Aug 29, 2018
05d011a to
52ed988
Compare
fabpot
approved these changes
Sep 4, 2018
|
Thank you @maidmaid. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
… var of PhpExecutableFinder (maidmaid) This PR was merged into the 4.2-dev branch. Discussion ---------- [Process] Add relative path support for PHP_BINARY env var of PhpExecutableFinder | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / At the moment, only the absolute path for PHP_BINARY env var works, for instance : ``` $ PHP_BINARY=/usr/bin/php7.2 php bin/console server:run [OK] Server listening on http://127.0.0.1:8000 $ PHP_BINARY=php7.2 php bin/console server:run [ERROR] Unable to find the PHP binary. ``` This PR makes possible the second command. Commits ------- 52ed988 Add relative path support for PHP_BINARY env var of PhpExecutableFinder
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, only the absolute path for PHP_BINARY env var works, for instance :
This PR makes possible the second command.