[Messenger][FrameworkBundle] Move commands-specifics to a compiler pass in FWB#28328
Merged
nicolas-grekas merged 1 commit intosymfony:4.1from Sep 1, 2018
Merged
Conversation
407f913 to
e973373
Compare
e973373 to
ee36550
Compare
sroze
commented
Sep 1, 2018
|
|
||
| $container | ||
| ->getDefinition('console.command.messenger_consume_messages') | ||
| ->replaceArgument(0, ServiceLocatorTagPass::register($container, $buses)) |
Contributor
Author
There was a problem hiding this comment.
These changes should not be merged into 4.1; I'll revert them.
37272af to
7a8c171
Compare
nicolas-grekas
requested changes
Sep 1, 2018
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Looks legit to me.
deps=low failures are hinting framework-bundle should require 4.1.5 as minimum version of messenger.
| $container->getDefinition($busId)->replaceArgument(0, $middlewareReferences); | ||
| } | ||
|
|
||
| public static function findReceivers(ContainerBuilder $container, string $receiverTag) |
Member
There was a problem hiding this comment.
should be @internal I suppose
67b8b00 to
aefce11
Compare
aefce11 to
b5415ea
Compare
nicolas-grekas
approved these changes
Sep 1, 2018
Member
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 1, 2018
…compiler pass in FWB (sroze) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger][FrameworkBundle] Move commands-specifics to a compiler pass in FWB | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28271 (comment) | License | MIT | Doc PR | ø We very recently [broke the tests](#28271 (comment)) by adding a legitimate BC-break in one of Messenger's command. The failure is on FrameworkBundle (on the 4.1 branch) when using the "latest" dependencies (so messenger on master): the XML configuration does not match anymore the class. Even though it makes sense to have most the compiler pass in the components, it does not make much sense to have things into them that are very coupled to what we defined in FWB' XML. This pull-request moves what is related to this command to the FWB directly. Commits ------- b5415ea Move commands-specifics to a compiler pass in FWB
nicolas-grekas
added a commit
that referenced
this pull request
Sep 2, 2018
…iler pass in FWB" (sroze) This PR was merged into the 4.1 branch. Discussion ---------- [FWB][Messenger] Revert "Move commands-specifics to a compiler pass in FWB" | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? |no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø This reverts #28328. Commits ------- fb3f729 Revert "Move commands-specifics to a compiler pass in FWB"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We very recently broke the tests by adding a legitimate BC-break in one of Messenger's command. The failure is on FrameworkBundle (on the 4.1 branch) when using the "latest" dependencies (so messenger on master): the XML configuration does not match anymore the class.
Even though it makes sense to have most the compiler pass in the components, it does not make much sense to have things into them that are very coupled to what we defined in FWB' XML. This pull-request moves what is related to this command to the FWB directly.