Codestin Search App

mcfedr · 2018-09-05T14:08:22Z

Q	A
Branch?	2.8
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#27233, #27254
License	MIT
Doc PR	N/A

Fix DateTimeType' HTML input format according to HTML specs. Currently DateTimeType produces html with format yyyy-MM-dd'T'HH:mm:ssZ but the HTML5 spec expects yyyy-MM-dd'T'HH:mm:ss (i.e. no Z). Chrome presents an empty date picker meaning edits or having a default date are broken.

Also the reverseTransform was expect to have a timezone attached, which it does not - and incorrectly marks it as being a UTC time in this case, instead of using the Transformers output TZ.

This is same as @franzwilding #27254 but with change to just straight use of DateTime::format and handling TZ in reverseTransform

nicolas-grekas · 2018-09-06T12:45:37Z

src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php

 use Symfony\Component\Form\Extension\Core\DataTransformer\ArrayToPartsTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\DataTransformerChain;
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToArrayTransformer;
+use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToHTML5DateTimeLocalTransformer;


case mismatch (see failing tests): should be Html5

Oops! Thanks.

nicolas-grekas

LGTM with just one minor comment

nicolas-grekas · 2018-09-07T12:29:52Z

...ny/Component/Form/Extension/Core/DataTransformer/DateTimeToHtml5DateTimeLocalTransformer.php

+ */
+class DateTimeToHtml5DateTimeLocalTransformer extends BaseDateTimeTransformer
+{
+    const HTML5_FORMAT = "Y-m-d\TH:i:s";


should use single quotes

Fixed, I've also put '\T' in the middle, as it looks more correct, it works with single \ because \T is not a valid combo, but really for a literal \ it should be \\

javiereguiluz · 2018-09-10T07:00:10Z

This is a bit confusing:

Resources like MDN never include the Z in the datetime format: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local
The official HTML5 spec seems to say that it's OK and valid to include it: https://www.w3.org/TR/2010/WD-html5-20101019/common-microsyntaxes.html#concept-datetime

franzwilding · 2018-09-10T07:07:16Z

@javiereguiluz The problem is, that Chrome do not support Z in datetime-local inputs, even if w3c says it is OK.

javiereguiluz · 2018-09-10T07:12:31Z

I see. In the past, we usually ignored issues like this considering them as browsers bugs (I remember a problem with a Safari-only behavior). But this is frustrating for users and Chrome is the most popular browser ... so it will be a tough decision.

franzwilding · 2018-09-10T07:42:13Z

@javiereguiluz I think in this case it is less a browser specific hack and more a more correct implementation of the datetime-local draft specs.

I think the whole idea of datetime-local is to be a datetime field without a timezone, this is also the description of the datetime-local field: https://www.w3.org/TR/2012/WD-html-markup-20120315/input.datetime-local.html

Also, when you see the reference of the date + time format (https://www.w3.org/TR/2012/WD-html-markup-20120315/datatypes.html#form.data.datetime-local) it clearly says that there should not be a timezone suffix.

javiereguiluz · 2018-09-10T07:46:23Z

@franzwilding thanks for the details. It's more clear to me now. Approved it!

mcfedr · 2018-09-10T08:38:40Z

I refered to the whatwg spec, which does not include Z - I think some of the confusion here is the difference between type=datetime and type=datetime-local, the former is deprecated and not used by symfony. It allowed timezones, but the handling was inconsistent and that is why its been removed.

datetime-local
date time format

xabbuh · 2018-09-15T09:29:37Z

...ny/Component/Form/Extension/Core/DataTransformer/DateTimeToHtml5DateTimeLocalTransformer.php

+        }
+
+        try {
+            $dateTime = new \DateTime($dateTimeLocal, new \DateTimeZone($this->outputTimezone));


I think we should check the format of the submitted date first to avoid issues like #28455 (the approach could IMO be similar to what I propose in #28466).

Makes sense, I've added something similar here.

nicolas-grekas · 2018-09-17T18:12:10Z

Thank you @mcfedr.

@franzwilding

…mcfedr) This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fix DateTimeType html5 input format | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27233, #27254 | License | MIT | Doc PR | N/A Fix DateTimeType' HTML input format according to HTML specs. Currently `DateTimeType` produces html with format `yyyy-MM-dd'T'HH:mm:ssZ` but the HTML5 spec expects `yyyy-MM-dd'T'HH:mm:ss` (i.e. no `Z`). Chrome presents an empty date picker meaning edits or having a default date are broken. Also the reverseTransform was expect to have a timezone attached, which it does not - and incorrectly marks it as being a UTC time in this case, instead of using the Transformers output TZ. This is same as @franzwilding #27254 but with change to just straight use of `DateTime::format` and handling TZ in reverseTransform Commits ------- e21a1a4 Added relevent links for parsing to the phpdoc 4f06f15 Add stricter checking for valid date time string 253d0a6 [Form] Fix DateTimeType html5 input format

nicolas-grekas · 2018-09-18T17:10:18Z

Could anyone please have a look at why this PR makes tests for 4.1 to fail?
See e.g. https://travis-ci.org/symfony/symfony/jobs/430138930

This PR was submitted for the master branch but it was merged into the 4.1 branch instead (closes #28504). Discussion ---------- [Form] Fix expected values in datetime-local test | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28372 | License | MIT | Doc PR | N/A Commits ------- 5ed8b27 Fix expected values in datetime-local test

carsonbot added Status: Needs Review Form Bug labels Sep 5, 2018

mcfedr force-pushed the datetime-html5-fix branch 7 times, most recently from 374dfbf to 67a95f4 Compare September 5, 2018 18:37

nicolas-grekas added this to the 2.8 milestone Sep 6, 2018

nicolas-grekas reviewed Sep 6, 2018

View reviewed changes

mcfedr force-pushed the datetime-html5-fix branch from 67a95f4 to 8839532 Compare September 6, 2018 17:11

nicolas-grekas approved these changes Sep 7, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Sep 7, 2018

nicolas-grekas mentioned this pull request Sep 7, 2018

[Form] Fix DateTimeType html5 input format. #27254

Closed

[Form] Fix DateTimeType html5 input format

253d0a6

mcfedr force-pushed the datetime-html5-fix branch from 8839532 to 253d0a6 Compare September 7, 2018 13:54

javiereguiluz approved these changes Sep 10, 2018

View reviewed changes

xabbuh mentioned this pull request Sep 14, 2018

DateTimeType HTML5 Chrome #22063

Closed

xabbuh reviewed Sep 15, 2018

View reviewed changes

mcfedr added 2 commits September 15, 2018 14:25

Add stricter checking for valid date time string

4f06f15

Added relevent links for parsing to the phpdoc

e21a1a4

mcfedr force-pushed the datetime-html5-fix branch from d6f0029 to e21a1a4 Compare September 15, 2018 11:34

xabbuh approved these changes Sep 15, 2018

View reviewed changes

nicolas-grekas merged commit e21a1a4 into symfony:2.8 Sep 17, 2018

mcfedr deleted the datetime-html5-fix branch September 18, 2018 10:06

mcfedr mentioned this pull request Sep 18, 2018

[Form] Fix expected values in datetime-local test #28504

Merged

xabbuh mentioned this pull request Sep 19, 2018

[Form] fail reverse transforming invalid RFC 3339 dates #28466

Merged

This was referenced Sep 30, 2018

Release v2.8.46 #28640

Merged

Release v3.4.16 #28641

Merged

Release v4.1.5 #28642

Merged

danrot mentioned this pull request Oct 2, 2018

fix datetime formatting for Symfony regression sulu/sulu#4180

Merged

trompette mentioned this pull request Oct 3, 2018

[Form] Do not fail reverse transforming relative dates #28703

Closed

This was referenced Oct 3, 2018

[Form] TransformationFailedException when submitting a ISO8601 date to a DateTimeType field #28699

Closed

clarify the datetime format option symfony/symfony-docs#10434

Merged

franzwilding mentioned this pull request Nov 12, 2018

Problem with type datetime unite-cms/unite-cms#364

Closed

Uh oh!

Conversation

mcfedr commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcfedr Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

mcfedr Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

javiereguiluz commented Sep 10, 2018

Uh oh!

franzwilding commented Sep 10, 2018

Uh oh!

javiereguiluz commented Sep 10, 2018

Uh oh!

franzwilding commented Sep 10, 2018

Uh oh!

javiereguiluz commented Sep 10, 2018

Uh oh!

mcfedr commented Sep 10, 2018

Uh oh!

xabbuh Sep 15, 2018

Choose a reason for hiding this comment

Uh oh!

mcfedr Sep 15, 2018

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Sep 17, 2018

Uh oh!

nicolas-grekas commented Sep 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mcfedr commented Sep 5, 2018 •

edited

Loading

nicolas-grekas Sep 6, 2018 •

edited

Loading