[DI] configure inlined services before injecting them when dumping the container#28388
Merged
nicolas-grekas merged 1 commit intosymfony:3.4from Sep 8, 2018
Merged
[DI] configure inlined services before injecting them when dumping the container#28388nicolas-grekas merged 1 commit intosymfony:3.4from
nicolas-grekas merged 1 commit intosymfony:3.4from
Conversation
This was referenced Sep 7, 2018
68147fb to
e5c5405
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 8, 2018
… dumping the container (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] configure inlined services before injecting them when dumping the container | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28304 | License | MIT | Doc PR | - #28060 introduced a change in the way inline services are dumped: these instances could end up being configured *after* being injected. This breaks e.g. using Doctrine's Configuration instances, which are expected to be fully defined before being injected into their consumers. Fixing this required a significant refactorization because I was just unable to reason with the heavily scrambled logic in place right now. The new logic is still non-trivial, but at least it's manageable, thus easier to get correct. (Replaces #28385 which is the same applied to 4.1 - should help with merges.) Commits ------- e5c5405 [DI] configure inlined services before injecting them when dumping the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28060 introduced a change in the way inline services are dumped: these instances could end up being configured after being injected. This breaks e.g. using Doctrine's Configuration instances, which are expected to be fully defined before being injected into their consumers.
Fixing this required a significant refactorization because I was just unable to reason with the heavily scrambled logic in place right now. The new logic is still non-trivial, but at least it's manageable, thus easier to get correct.
(Replaces #28385 which is the same applied to 4.1 - should help with merges.)